Skip to content

DRAFT [py]: increase fedcm tests timeout #15582

Closed
navin772 wants to merge 3 commits into
SeleniumHQ:trunkfrom
navin772:fedcm-timeout
Closed

DRAFT [py]: increase fedcm tests timeout #15582
navin772 wants to merge 3 commits into
SeleniumHQ:trunkfrom
navin772:fedcm-timeout

Conversation

@navin772

@navin772 navin772 commented Apr 6, 2025

Copy link
Copy Markdown
Member

🔗 Related Issues

💥 What does this PR do?

Debug FedCM timeout error on Linux

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Bug fix (backwards compatible)

@selenium-ci selenium-ci added the C-py Python Bindings label Apr 6, 2025
@cgoldberg

Copy link
Copy Markdown
Member

I can't get the dialog to open at all, even with driver.fedcm_dialog(timeout=60)

@navin772

navin772 commented Apr 6, 2025

Copy link
Copy Markdown
Member Author

@cgoldberg yeah, it's weird that its happening for those 2 tests only since the chrome update (and only on linux!)

@cgoldberg

Copy link
Copy Markdown
Member

@navin772 after more testing, I actually can get it to open.. it just takes a little bit. I think raising the timeout to 15 secs should resolve this.

@navin772

navin772 commented Apr 6, 2025

Copy link
Copy Markdown
Member Author

I raised it to 20 sec for testing. Although, for me the dialog appears almost instantly in linux. Let's see if this passes else we might have to skip those 2 for now and test in later versions.

@cgoldberg

Copy link
Copy Markdown
Member

This PR shouldn't be needed now.. We can land #15583 instead.

@navin772 navin772 closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants