DRAFT [py]: increase fedcm tests timeout #15582
Closed
navin772 wants to merge 3 commits into
Closed
Conversation
Member
|
I can't get the dialog to open at all, even with |
Member
Author
|
@cgoldberg yeah, it's weird that its happening for those 2 tests only since the chrome update (and only on linux!) |
Member
|
@navin772 after more testing, I actually can get it to open.. it just takes a little bit. I think raising the timeout to 15 secs should resolve this. |
Member
Author
|
I raised it to 20 sec for testing. Although, for me the dialog appears almost instantly in linux. Let's see if this passes else we might have to skip those 2 for now and test in later versions. |
Member
|
This PR shouldn't be needed now.. We can land #15583 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
💥 What does this PR do?
Debug FedCM timeout error on Linux
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes