[dotnet] Add nullability annotations to Proxy

[RenderMichael]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add nullability annotations to Proxy. Dictionary lookups are significantly improved, with double- or triple-lookups turning into a single one.

Motivation and Context

Contributes to #14640

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

enhancement

---

Description

• Added nullability annotations to the Proxy class to improve code safety and clarity.
• Optimized dictionary lookups by replacing multiple lookups with TryGetValue method calls.
• Enhanced error handling by adding exceptions for null elements in lists.
• Simplified property getters using expression-bodied members for cleaner code.

---

Changes walkthrough 📝

	Relevant files
Enhancement	Proxy.cs Add nullability annotations and optimize dictionary lookups dotnet/src/webdriver/Proxy.cs Enabled nullability annotations for the Proxy class. Improved dictionary lookups by using TryGetValue. Added exception handling for null elements in lists. Simplified property getters using expression-bodied members. +65/-101

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Null Reference The TryGetValue pattern used throughout the constructor could still lead to null reference issues if ToString() is called on a null object value. Additional null checks may be needed. Exception Handling The new ArgumentException for null elements in noProxy list could cause runtime failures for existing code that previously handled nulls silently. Consider logging warnings instead.

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Use pattern matching with Array type instead of direct casting to handle different array types safely The addressesAsArray array is cast directly to object?[] which could fail at runtime if the array is of a different type. Use pattern matching with is to safely handle different array types. dotnet/src/webdriver/Proxy.cs [138-144] -else if (noProxy is object?[] addressesAsArray) +else if (noProxy is Array addressesAsArray) { - foreach (object? address in addressesAsArray) + foreach (var address in addressesAsArray) { bypassAddresses.Add(address?.ToString() ?? throw new ArgumentException("noProxy list contained null element", nameof(settings))); } } Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion improves type safety by using pattern matching with the more general Array type instead of a specific array type, preventing potential runtime casting exceptions when handling different array types.	7

💡 Need additional feedback ? start a PR chat

[nvborisenko]

Thx Michael!