[py] fix packaging#14823
Merged
Merged
Conversation
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
12be491 to
8242178
Compare
navin772
reviewed
Nov 28, 2024
navin772
left a comment
Member
There was a problem hiding this comment.
Thanks @benoit-pierre for adding __init__.py to fedcm.
LGTM!
Member
|
@benoit-pierre can you also add the License headers to the file, it is required |
Ensure `selenium.webdriver.common.fedcm` gets packaged in.
8242178 to
0e5bc8e
Compare
Member
|
@navin772, do you have any idea on how to detect this issue via test, or CI when a new package would be added in future? |
Contributor
|
You could run tests on installed package, i.e. in Gentoo we do the equivalent of: |
Member
|
Thanks for your suggestion! |
Member
|
@VietND96 we can add a pre-check in python build CI that checks recursively inside |
1 task
13 tasks
13 tasks
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Feb 5, 2025
see SeleniumHQ/selenium#14823 Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
13 tasks
misuzu
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Feb 6, 2025
Updated version fails to build on x86_64-linux due to an update of selenium, see issue SeleniumHQ/selenium#14823.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
Ensure
selenium.webdriver.common.fedcmgets packaged in.Types of changes
Checklist
PR Type
Bug fix
Description
selenium.webdriver.common.fedcmis included in the package distribution.fedcmmodule files.Changes walkthrough 📝