[java] case insensitive header names in http requests

[iampopovich]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

I opened PR with initial changes. i have already asked some questions about feature in feature request ticket
I will implement new tests as soon as I get more information about task details

Motivation and Context

according to #12697 I started to discover how to implement this feature

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Normalize header names to lowercase in setHeader method to ensure case-insensitive handling.
• Normalize header names to lowercase in addHeader method to ensure case-insensitive handling.

---

Changes walkthrough 📝

	Relevant files
Enhancement	HttpMessage.java Normalize header names to lowercase in HTTP message handling. java/src/org/openqa/selenium/remote/http/HttpMessage.java Convert header names to lowercase in setHeader method. Convert header names to lowercase in addHeader method. +2/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-code-review]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are limited to a few lines in a single file, modifying header handling to be case-insensitive. The logic is straightforward, but the impact on existing functionality should be carefully evaluated.
🧪 Relevant tests	No
⚡ Possible issues	Consistency Issue: The PR changes headers to be stored in lowercase, which might affect other parts of the system that rely on the original case format of headers.
🔒 Security concerns	No

[qodo-code-review]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Add a null check for the name parameter to prevent NullPointerException Consider adding a null check for the name parameter before converting it to lowercase to avoid potential NullPointerException. java/src/org/openqa/selenium/remote/http/HttpMessage.java [126] +if (name == null) { + throw new IllegalArgumentException("Header name cannot be null"); +} return removeHeader(name).addHeader(name.toLowerCase(), value); Apply this suggestion Suggestion importance[1-10]: 8 Why: Adding a null check is crucial to prevent runtime exceptions when the 'name' parameter is null. This is a significant improvement for robustness.	8
Best practice	Use Locale.ROOT in toLowerCase to ensure consistent behavior across locales Consider using Locale.ROOT in the toLowerCase method to ensure consistent behavior across different locales. java/src/org/openqa/selenium/remote/http/HttpMessage.java [126] -return removeHeader(name).addHeader(name.toLowerCase(), value); +return removeHeader(name).addHeader(name.toLowerCase(Locale.ROOT), value); Apply this suggestion Suggestion importance[1-10]: 7 Why: Using Locale.ROOT for toLowerCase ensures consistent behavior across different system locales, which is important for the predictability of HTTP header handling.	7

[titusfortner]

Let's at least wait to merge this after the upcoming release so that Appium can run their tests against nightly and see if it causes them problems before a production release.

[diemol]

Thank you, @iampopovich!

[diemol]

Several tests failed. Can you please check?

[iampopovich]

@diemol sure
The FederatedCredentialManagementTest could not be executed due to a process creation error on Windows, related to the long path to the executable file. As a result, the test failed three times, despite the successful execution of other tests.

This failure occurs frequently in test runs on Windows and is not directly related to the changes in the pull request.

[iampopovich]

i found issue that can help fix it bazelbuild/bazel#19710

[diemol]

I meant this ones https://github.com/SeleniumHQ/selenium/actions/runs/10321185029/job/28573474046?pr=14095

[iampopovich]

oh...i see
I mentioned this in the feature request here. The failing tests need to be fixed under the assumption that headers are now case-insensitive. I will correct the existing tests and resubmit them for review.

[iampopovich]

@diemol please verify my changes in tests
I tried to preserve the logic of the checks, considering that header names are now case-insensitive. I also fixed the HttpMessage.setHeader method. Previously, it couldn't remove a header because the headers were set in lowercase, while the name was passed in an arbitrary case.

public M setHeader(String name, String value) {
    return removeHeader(name.toLowerCase()).addHeader(name.toLowerCase(), value);
}

[iampopovich]

i noticed the problem with the formatting 👀

[iampopovich]

@diemol i fixed the tests with headers