Skip to content

[java] remove guava from client bindings #12737 #13739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joerg1985 wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

[java] remove guava from client bindings #12737 #13739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b7153
[java] remove guava from client bindings #12737
joerg1985 Mar 26, 2024
7ab9a49
Merge branch 'trunk' into removed-guava-from-the-client
asolntsev Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion java/src/org/openqa/selenium/support/ui/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ java_library(
":clock",
"//java/src/org/openqa/selenium:core",
"//java/src/org/openqa/selenium/remote",
artifact("com.google.guava:guava"),
artifact("org.jspecify:jspecify"),
],
)
5 changes: 2 additions & 3 deletions java/src/org/openqa/selenium/support/ui/ExpectedCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

package org.openqa.selenium.support.ui;

import com.google.common.base.Function;
import java.util.function.Function;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;
import org.openqa.selenium.WebDriver;
Expand All @@ -37,5 +37,4 @@
// such as "com.google.common.base.Function condition = ExpectedConditions.elementFound(By);"
// breaking at compile time, we continue to extend Guava's Function interface.
@NullMarked
public interface ExpectedCondition<T extends @Nullable Object>
extends Function<WebDriver, T>, java.util.function.Function<WebDriver, T> {}
public interface ExpectedCondition<T extends @Nullable Object> extends Function<WebDriver, T> {}
13 changes: 6 additions & 7 deletions java/src/org/openqa/selenium/support/ui/ExpectedConditions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@

package org.openqa.selenium.support.ui;

import com.google.common.base.Joiner;
import java.util.Arrays;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;
import org.openqa.selenium.Alert;
Expand Down Expand Up @@ -1421,9 +1422,8 @@ public Boolean apply(WebDriver driver) {

@Override
public String toString() {
StringBuilder message = new StringBuilder("at least one condition to be valid: ");
Joiner.on(" || ").appendTo(message, conditions);
return message.toString();
return "at least one condition to be valid: "
+ Arrays.stream(conditions).map(Objects::toString).collect(Collectors.joining(" || "));
}
};
}
Expand Down Expand Up @@ -1458,9 +1458,8 @@ public Boolean apply(WebDriver driver) {

@Override
public String toString() {
StringBuilder message = new StringBuilder("all conditions to be valid: ");
Joiner.on(" && ").appendTo(message, conditions);
return message.toString();
return "all conditions to be valid: "
+ Arrays.stream(conditions).map(Objects::toString).collect(Collectors.joining(" && "));
}
};
}
Expand Down
Loading