refactor(util): Eliminate side-effects on import #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the util.promisify() call in src/util.ts from the top level to execBashCommand(). Mock util.promisify() in tests now that it is simpler to do so before util.promisify() is called. Introduce src/mocks/util.ts to share the util mock factory between tests.
Contributor
Author
|
I was able to simplify considerably by replacing some unnecessary uses of |
mwarres
reviewed
Mar 28, 2023
mwarres
reviewed
Mar 28, 2023
Contributor
mwarres
left a comment
There was a problem hiding this comment.
Looks good overall, I'm not sure about the syntax on the area I commented on though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
util.promisify()call insrc/util.tsfrom the top level toexecBashCommand(). Mockutil.promisify()in tests now that it is simpler to do so beforeutil.promisify()is called. Introducesrc/mocks/util.tsto share the util mock factory between tests.