Support Ponder subgraph schemas in umbra-js and frontend#712
Support Ponder subgraph schemas in umbra-js and frontend#712garyghayrat wants to merge 4 commits into
Conversation
✅ Deploy Preview for jolly-shaw-20fe62 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
950acc6 to
3d133c8
Compare
Add compatibility fetching and tests for both Ponder and legacy subgraph schemas, wire frontend chain configs to explicit subgraph URLs, and restore the frontend Umbra API default to the production endpoint.
3d133c8 to
f745cc0
Compare
marcomariscal
left a comment
There was a problem hiding this comment.
Requesting changes: PONDER_SUBGRAPH_URL is now required in practice, but missing it silently disables subgraph scanning. The current deploy preview bundle has no Ponder URL, so L2 receive scans fall back to RPC and throw on Optimism/Polygon/Base.
Please fail the build or keep the legacy per-chain fallback until the new env is configured everywhere. Also add a smoke test we can run against preview/prod that verifies the built app has a Ponder URL and a basic Ponder scan succeeds.
|
marcomariscal
left a comment
There was a problem hiding this comment.
Looks good. Gary addressed the requested fallback/build-guard issue and added the preview/prod Ponder smoke test. I ran the smoke test against the Netlify preview and it passed.
Summary
Testing
umbra-js/test/subgraph-schema.test.tsResults
Older accounts benefit the most, and newer accounts not as much (like the base example).
Average percentage improvement across chains: 40.0%