feat: file watcher in independent process for linux#772
Conversation
|
CI/CD-related files cannot be changed in pull requests unless the author is listed in Violating files:
This guard reads the protected list from |
|
/oc review |
1 similar comment
|
/oc review |
|
I have enough information from the diff to produce a thorough review. Let me summarize what I've seen and identify the key issues. This PR adds a Go sidecar for file watching on Linux (to avoid inotify watch limit crashes), introduces an Here is my review: The PR implements a solid architecture for Linux file watching via a Go sidecar and active-directory lease scoping, but has a few issues worth addressing.
|
|
1.sdk为自动生成,出现 |
Issue for this PR
Closes #
Type of change
What does this PR do?
linux平台由于inotify递归监听需要在每一个子目录建立watcher,容易超出
/proc/sys/fs/inotify/max_user_watches上限导致进程终止,表现为打开大目录时闪退。因此file-watcher需要运行在独立进程中,考虑到bun多进程的复杂性以及性能开销,选择go写sidecar。主要功能:支持linux平台的文件监听;判断当前活跃目录,不监听非活跃目录;
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
bun typecheck
bun run test test/file/watcher.test.ts
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.