Skip to content

1496 smm model output is misaligned with time points #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kilianvolmer merged 4 commits into from
Feb 25, 2026
Merged

1496 smm model output is misaligned with time points #1497

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef8a144
FIX: Store next time point instead of current time point
kilianvolmer Feb 24, 2026
4977d13
CHG: Store x*dt time point before event and time point after event(s)
kilianvolmer Feb 24, 2026
e6e32e3
CHG: Only store x*dt time after next event
kilianvolmer Feb 24, 2026
fd239b3
CHG: Update comments
kilianvolmer Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions cpp/models/smm/simulation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,20 @@ class Simulation
update_current_rates_and_waiting_times();
size_t next_event = determine_next_event(); // index of the next event
FP current_time = m_result.get_last_time();
// set in the past to add a new time point immediately
FP last_result_time = current_time - m_dt;
// set current time to add next time point in the future
FP last_result_time = current_time;
// iterate over time
while (current_time + m_waiting_times[next_event] < tmax) {
// update time
current_time += m_waiting_times[next_event];
// regularily save current state in m_results
if (current_time > last_result_time + m_dt) {
last_result_time = current_time;
m_result.add_time_point(current_time);
// If the next event happens further in the future than the next stored time point, add a new one.
if (current_time + m_waiting_times[next_event] >= last_result_time) {
auto num_dt = std::ceil((current_time + m_waiting_times[next_event] - last_result_time) / m_dt);
last_result_time = std::min(tmax, last_result_time + num_dt * m_dt);
m_result.add_time_point(last_result_time);
// copy from the previous last value
m_result.get_last_value() = m_result[m_result.get_num_time_points() - 2];
}
// update time
current_time += m_waiting_times[next_event];
// decide event type by index and perform it
if (next_event < adoption_rates().size()) {
// perform adoption event
Expand Down