1382 Fix incorrect overload detection and type mismatch in test_commuters#1394
Merged
julianlitz merged 2 commits intomainfrom Oct 27, 2025
Merged
1382 Fix incorrect overload detection and type mismatch in test_commuters#1394julianlitz merged 2 commits intomainfrom
test_commuters#1394julianlitz merged 2 commits intomainfrom
Conversation
test_commuters
julianlitz
commented
Oct 13, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
- Coverage 97.26% 97.25% -0.02%
==========================================
Files 176 176
Lines 15439 15446 +7
==========================================
+ Hits 15017 15022 +5
- Misses 422 424 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reneSchm
reviewed
Oct 14, 2025
reneSchm
reviewed
Oct 15, 2025
reneSchm
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
This PR fixes several issues preventing the correct
test_commutersoverload from being selected.test_commutersimplementation was always selected.constfromEigen::Ref<const Eigen::VectorX<FP>>intest_commuters_expr_tand corrected the default template parameter tomio::Simulation<FP, Model<FP>>.FPtemplate parameter tois_expression_valid<test_commuters_expr_t, FP, Sim>::value.After these changes, the correct overload is now detected and executed. Verified with
ode_secir_graph.cppwhere commuter testing runs as intended.Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1382, #1383, #1384