Skip to content

Feature/fixing camera problems#49

Merged
smallTrogdor merged 15 commits intomainfrom
feature/fixing-camera-problems
Nov 7, 2025
Merged

Feature/fixing camera problems#49
smallTrogdor merged 15 commits intomainfrom
feature/fixing-camera-problems

Conversation

@soracel
Copy link
Copy Markdown
Contributor

@soracel soracel commented Sep 26, 2025

Proposed changes

Added a workaround to convert images to the NV21 format, since ML Kit currently does not support other formats.
This workaround should be removed once flutter/packages#10022 is merged.

Fixes

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@soracel soracel self-assigned this Sep 26, 2025
@soracel soracel requested review from smallTrogdor and removed request for smallTrogdor September 26, 2025 12:22
Copy link
Copy Markdown
Collaborator

@smallTrogdor smallTrogdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I left some remarks, especially about the Changelog. Otherwise just nitpicks

Comment thread .github/workflows/test.yml Outdated
Comment thread CHANGELOG.md Outdated
Comment thread ci/.release-please-manifest.json Outdated
Comment thread example/android/app/build.gradle Outdated

defaultConfig {
applicationId "ch.sbb.datascanner.example"
minSdkVersion 21
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably easier to leave at Flutter.minSDKVersion ...

Comment thread example/android/app/build.gradle Outdated
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 11 ?

Comment thread lib/extensions/camera_image_x.dart
Comment thread lib/widgets/sized_camera_preview.dart
Comment thread test/extensions/camera_image_extension_test.dart
Comment thread test/extensions/camera_image_extension_test.dart Outdated
Comment thread test/extensions/camera_image_extension_test.dart Outdated
chore: update flutter version to 3.35.0

refactor: nitpicks
Copy link
Copy Markdown
Collaborator

@smallTrogdor smallTrogdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮 ✅

@smallTrogdor smallTrogdor marked this pull request as ready for review November 7, 2025 11:53
@smallTrogdor smallTrogdor requested a review from a team as a code owner November 7, 2025 11:53
@smallTrogdor smallTrogdor merged commit 7f1f4eb into main Nov 7, 2025
8 checks passed
@smallTrogdor smallTrogdor deleted the feature/fixing-camera-problems branch November 7, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants