Don't include magnetism parameters in pure python models#3961
Conversation
There was a problem hiding this comment.
Locally, I am seeing a failing unit test. A pure python model is used to test the magnetic parameters, so this unit test should be updated.
src\sas\qtgui\Perspectives\Fitting\UnitTesting\FittingWidgetTest.py:666: AssertionError
assert widget.magnetism_widget._magnet_model.rowCount() == 10
E assert 0 == 10
There was a problem hiding this comment.
The test is failing because the absorbed layer model does not support magnetism.
I changed it to use the core-shell sphere model which does support magnetism.
The tests now pass locally (after modifying pyproject.toml to exclude src/sas/webfit).
krzywon
left a comment
There was a problem hiding this comment.
Unit tests are now passing.
|
Since we have a functionality and code review, I am merging this to create the new alpha. |
* don't include magnetism parameters in pure python models * update magnetism test to use a model that supports magnetism --------- Co-authored-by: Paul Kienzle <pkienzle@nist.gov>
|
I was just testing the test installer for the third alpha. I found that selecting octahedron_truncated is giving an error, while the others are working okay |
|
Description
Use the model info interpreter from sasmodels.modelinfo rather than calling the internal modelinfo.make_parameter_table directly.
Fixes sasmodels #732
How Has This Been Tested?
The new tetrahedron pure python model loads without magnetism support, and the exist cylinder model loads with magnetism support.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)