Release 6.0.0: Show 404 message instead of regen#3131
Conversation
wpotrzebowski
left a comment
There was a problem hiding this comment.
Tested on Mac. It works as expected
smk78
left a comment
There was a problem hiding this comment.
Functionality test of build actions/runs/11466159520 on W10/x64.
Ran SasView. Went to the FitPage and selected Plugin Models and loaded a plugin in my plugins folder previously downloaded from the Marketplace (peak_voight). Computed the theory. Clicked Help...
At this point a full rebuild of all model documentation started (not just the plugins)! Somewhat tiresome.
This eventually returned this:

13:22:51 - ERROR: Traceback (most recent call last): File "sasmodels\generate.py", line 1177, in load_kernel_module __import__('sasmodels.models.'+model_name) ModuleNotFoundError: No module named 'sasmodels.models.C:\\Users\\smk78\\' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "sas\sascalc\doc_regen\makedocumentation.py", line 245, in make_documentation File "sas\sascalc\doc_regen\makedocumentation.py", line 214, in call_one_file File "sas\sascalc\doc_regen\makedocumentation.py", line 128, in call_regenmodel File "sas\sascalc\doc_regen\regenmodel.py", line 358, in process_model File "sasmodels\core.py", line 173, in load_model_info kernel_module = generate.load_kernel_module(model_string) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "sasmodels\generate.py", line 1185, in load_kernel_module kernel_module = load_custom_kernel_module(model_name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "sasmodels\custom\__init__.py", line 61, in load_custom_kernel_module if need_reload(path): ^^^^^^^^^^^^^^^^^ File "sasmodels\custom\__init__.py", line 116, in need_reload return any(cache_time return any(cache_time
13:22:51 - INFO: Documentation regeneration completed.
…sic fitting help (for now)
|
Tested build actions/runs/11483417062 on W10/x64. If you click Help on a FitPage with a plugin from the Marketplace the Documentation window now directs to fitting_help.html. The intended (hopefully) short-term workaround. However, if you do the same thing for a plugin generated by Add/Multiply Models you still get the 'Your file could not be accessed' error above. |
|
Tested build actions/runs/11500170818 on W10/x64. Both Marketplace plugins and Add/Multiply plugins now bring up fitting_help.html |
Description
This fixes the documentation issue noted by @wpotrzebowski in #3129 (comment). The Mac rst files were all newer than the html files, which triggered the doc generation. Nothing (as of 11:52 EST 10/23) should trigger the documentation generation process at this point. If the files cannot be found, a 404 error will be shown instead of the documentation generation.
Tested using the installer from https://github.com/SasView/sasview/actions/runs/11465366459 and this fix seems to work.