os/board/rtl8730e: Return error code when FTL write fail #7046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
r-prabu
reviewed
Nov 20, 2025
|
|
||
| //ftl_page_write(g_pPage + g_cur_pageID, g_free_cell_index + 1, key); | ||
| ftl_page_write(g_pPage + g_cur_pageID, g_free_cell_index, w_data); | ||
| ret = ftl_page_write(g_pPage + g_cur_pageID, g_free_cell_index, w_data); |
Collaborator
There was a problem hiding this comment.
Changes to propagate the error code form ftl_page_write is looking fine.
giwon-nam
reviewed
Nov 24, 2025
|
|
||
| //ftl_page_write(g_pPage + g_cur_pageID, g_free_cell_index + 1, key); | ||
| ftl_page_write(g_pPage + g_cur_pageID, g_free_cell_index, w_data); | ||
| ret = ftl_page_write(g_pPage + g_cur_pageID, g_free_cell_index, w_data); |
Contributor
There was a problem hiding this comment.
It seems unlikely that this part will actually return fail and then return success at the next location.
However, there might be an issue where the return value gets overwritten.
-Return error code when FTL write fail
312498b to
ee96090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Return error code when FTL write fail