os/arch,board: consolidate PINs definitions #7002
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-prabu
reviewed
Oct 17, 2025
ewoodev
reviewed
Oct 20, 2025
ewoodev
reviewed
Oct 20, 2025
e927715 to
7955db7
Compare
ewoodev
reviewed
Nov 14, 2025
os/board/rtl8730e/src/board_pins.c
Outdated
Comment on lines
33
to
40
| #if defined(CONFIG_RTL8730E_BOARD_AIL) || defined(CONFIG_RTL8730E_BOARD_AILP) || defined(CONFIG_RTL8730E_BOARD_AILPW) | ||
| // UART1 | ||
| {_PA_9, GPIO_PuPd_UP, GPIO_PuPd_UP}, | ||
| {_PA_10, GPIO_PuPd_UP, GPIO_PuPd_UP}, | ||
| #elif defined(CONFIG_RTL8730E_BOARD_AID) | ||
| {_PA_4, GPIO_PuPd_UP, GPIO_PuPd_UP}, | ||
| {_PA_5, GPIO_PuPd_DOWN, GPIO_PuPd_DOWN}, | ||
| #endif |
Contributor
There was a problem hiding this comment.
Can we seperate this file to each board?
ewoodev
reviewed
Nov 14, 2025
| ************************************************************************************/ | ||
| /* File name: rtl8730e_aid_board_pins.h */ | ||
|
|
||
| #ifndef RTL8730E_AID_BOARD_PINS_H |
Contributor
There was a problem hiding this comment.
This file is seems just cal count each board.
How about make this file to common and move the error checking to each board_pins.c
#error Not Supported, Please check the board type configure
sorry for confusing my prev comment
Contributor
There was a problem hiding this comment.
@ewoodev : board_pins.c will be for each board separately. like rtl8730e_aid_board_pins.c, rtl8730e_ailp_board_pins.c, etc.
and depending upon board type, one of these files will get into build using board type CONFIG option.
is it ok ?
0f2df12 to
4a09cad
Compare
This patch consolidates all definitions related to PINs being used for rtl8730e board. This version changes - creates one board specific file board_pins.c and modified one board specific file board_pins.h - board_pins.c Have all the board pins which are accessed according to enabled and disabled perpheral. - Disabled peripheral pins are mentioned as unused pins - Enabled peripheral pins are used in the pin_table start - board_pins.h used for accesing pin_table using Macro based indexing, It is called from the peripherals. - Pins are assigned during runtime.
4a09cad to
e08e2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch consolidates all definitions related to PINs being used for rtl8730e board. This version changes