Skip to content

Better features options #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgantzos merged 2 commits into from
Jun 23, 2024
Merged

Better features options #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b614996
better-popup-options
txruno Jun 23, 2024
a97314e
Updated color options
txruno Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 23 additions & 18 deletions extras/popup/popup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,6 @@ a {

.feature label {
color: var(--primary-color);
position: relative;
top: -0.7rem;
margin-left: 0.5rem;
}

.feature input[type="checkbox"] {
display: inline-block;
width: 1.25rem;
cursor: pointer;
}

.feature > span {
Expand Down Expand Up @@ -108,9 +99,10 @@ a {
margin-bottom: 0rem;
}
.feature p {
color: var(--secondary-color);
margin: 5px 0;
opacity: 0.5;
padding-right: 4rem;
color: var(--secondary-color);
}

.feature > input {
Expand All @@ -121,19 +113,18 @@ a {
.feature input {
padding: 0.1vw;
height: 2rem;
margin-left: 0.5vw;
background-color: var(--theme);
margin-left: auto;
border-radius: 1rem;
outline: none;
border: 0px;
background-color: var(--theme);
color: white;
}

.feature input {
color: var(--color);
background-color: var(--feature-input-bg);
padding-left: 1rem !important;
margin-bottom: 0.5rem;
}
.feature button {
cursor: pointer;
Expand Down Expand Up @@ -242,14 +233,25 @@ a {
.feature input {
padding: 0.1vw;
height: 2rem;
margin-left: 0.5vw;
margin-left: auto;
border-radius: 1rem;
outline: none;
border: 0px;
color: white;
background-color: var(--feature-input-bg);
}

.feature input[type="checkbox"] {
display: inline-block;
width: 1.25rem;
min-width: 55px;
cursor: pointer;
}
.feature input[type="color"] {
padding: 0.1vw !important;
border-radius: 0.4rem;
}

/*Switch*/
.switch {
position: relative;
Expand Down Expand Up @@ -435,14 +437,17 @@ span.new-feature-tag.beta {
}

.special-switch {
position: relative;
width: 55px;
height: 28px;
margin-left: auto;
transform: scale(80%);
float: right;
position: relative;
top: -0.25rem;
margin: 0px;
}

.feature .option {
display: flex;
margin: 5px 0;
align-items: center;
}

.feature table,
Expand Down
37 changes: 14 additions & 23 deletions extras/popup/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,42 +686,33 @@ async function getFeatures() {
for (var optionPlace in feature.options) {
var option = feature.options[optionPlace];
var input = document.createElement("input");
input.type = ["text", "checkbox", "number", "color"][option.type || 0];
input.dataset.id = option.id;
input.dataset.feature = feature.id;
input.placeholder = option.name;
input.type = ["text", "checkbox", "number", "color"][option.type || 0];
var optionData = (await chrome.storage.sync.get(option.id))[option.id];
input.value = optionData || "";
input.placeholder = `Enter ${input.type}`;
var optionDiv = document.createElement("div")
optionDiv.className = "option";
var label = document.createElement("label");
label.textContent = option.name;
optionDiv.appendChild(label)

if (input.type === "checkbox") {
input.checked = optionData || false;
var specialLabel = document.createElement("label");
specialLabel.className = "special-switch";
input.className = "checkbox"
input.classList.add = "checkbox"
var span = document.createElement("span");
span.className = "slider round";
specialLabel.appendChild(input);
specialLabel.appendChild(span);
optionDiv.appendChild(specialLabel)
} else {
div.appendChild(input);
}
if (input.type === "checkbox") {
let table = document.createElement("table")
let tr = document.createElement("tr")
table.appendChild(tr)

let td1 = document.createElement("td")
tr.appendChild(td1)
let td2 = document.createElement("td")
tr.appendChild(td2)

div.appendChild(table)

var label = document.createElement("label");
label.textContent = option.name;
label.style.marginLeft = "0px"
td1.appendChild(label);
td2.appendChild(specialLabel)
input.checked = optionData || false;
optionDiv.appendChild(input)
}
div.appendChild(optionDiv)

input.dataset.validation = btoa(
JSON.stringify(option.validation || [])
);
Expand Down
23 changes: 14 additions & 9 deletions extras/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ a {
}

.feature p {
margin: 5px 0;
opacity: 0.5;
font-size: 0.8rem;
padding-right: 4rem;
Expand All @@ -131,11 +132,10 @@ a {
.feature input {
padding: 0.1vw;
height: 2rem;
margin-left: 0.5vw;
margin-left: auto;
border-radius: 1rem;
outline: none;
padding-left: 1rem;
margin-bottom: 0.5rem;
border: 0px;
color: var(--primary-color);
background-color: var(--feature-input-bg);
Expand All @@ -144,8 +144,13 @@ a {
.feature input[type="checkbox"] {
display: inline-block;
width: 1.25rem;
min-width: 55px;
cursor: pointer;
}
.feature input[type="color"] {
padding: 0.1vw;
border-radius: 0.4rem;
}

.feature > input {
display: block;
Expand Down Expand Up @@ -188,9 +193,6 @@ a {

.feature label {
color: var(--primary-color);
position: relative;
top: -0.7rem;
margin-left: 0.5rem;
}

.feature > span {
Expand Down Expand Up @@ -793,14 +795,17 @@ span.new-feature-tag.beta {
}

.special-switch {
position: relative;
width: 55px;
height: 28px;
margin: 0px;
margin-left: auto;
transform: scale(80%);
float: right;
position: relative;
top: -0.25rem;
}

.feature .option {
display: flex;
margin: 5px 0;
align-items: center;
}

.feature table,
Expand Down