Skip to content

[autobackport: sssd-2-9] adding subid test#8294

Merged
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8225-to-sssd-2-9
Mar 25, 2026
Merged

[autobackport: sssd-2-9] adding subid test#8294
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8225-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8225 adding subid test to branch sssd-2-9, created by @danlavu.

Caution

@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8225-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8225-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8225-to-sssd-2-9 --force

Original commits
449913a - adding subid test

Backported commits

  • 5f9a380 - CONFLICT! adding subid test

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! adding subid test
On branch SSSD-sssd-backport-pr8225-to-sssd-2-9
You are currently cherry-picking commit 449913a8a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   src/tests/system/tests/test_ipa.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a new test file, src/tests/system/tests/test_ipa.py, which adds a comprehensive suite of system tests for SSSD's integration with FreeIPA. The new tests cover a wide range of features, including SSH public keys, ID views, HBAC rules, smart card authentication, and the subordinate ID (subid) functionality mentioned in the PR title. While the majority of the tests are well-structured, I've identified two tests related to ID views that don't actually validate SSSD's behavior on the client. Instead, they test the IPA server's command-line interface. These tests should be either corrected to verify client-side functionality or removed as they are out of scope for the SSSD test suite.

Comment thread src/tests/system/tests/test_ipa.py Outdated
Comment thread src/tests/system/tests/test_ipa.py Outdated
@danlavu
Copy link
Copy Markdown

danlavu commented Dec 10, 2025

@alexey-tikhonov Did you want this subid test ported to 2-9?

@alexey-tikhonov
Copy link
Copy Markdown
Member

@alexey-tikhonov Did you want this subid test ported to 2-9?

Imo it makes sense.

@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch from 5f9a380 to ddb1de7 Compare January 6, 2026 16:05
Copy link
Copy Markdown
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov
Copy link
Copy Markdown
Member

LGTM

@jakub-vavra-cz, test is failing to start:

 ValueError: Required field 'requirement' is missing for 'tests/test_ipa.py::test_ipa__subids_configured (ipa)'

@danlavu, please rebase.

@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch 2 times, most recently from e98fc9c to 1ed3d6e Compare January 26, 2026 15:17
@danlavu
Copy link
Copy Markdown

danlavu commented Jan 26, 2026

Since test_ipa.py in 2-9 has a single test case, the requirement field is missing. I added one.

@danlavu danlavu marked this pull request as ready for review January 26, 2026 15:18
@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch from 1ed3d6e to d7604c1 Compare March 25, 2026 13:08
@danlavu
Copy link
Copy Markdown

danlavu commented Mar 25, 2026

rebased, pushed.

@alexey-tikhonov
Copy link
Copy Markdown
Member

python-system-tests are failing.

@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch 3 times, most recently from ae2b25a to a25c42c Compare March 25, 2026 15:49
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Mar 25, 2026
@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch from a25c42c to 7b789c0 Compare March 25, 2026 17:12
(cherry picked from commit 449913a)
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch from 7b789c0 to 0ac509b Compare March 25, 2026 18:36
@alexey-tikhonov alexey-tikhonov merged commit 6f0c480 into SSSD:sssd-2-9 Mar 25, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only. Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants