Skip to content

Conversation

@cmester0
Copy link
Collaborator

@cmester0 cmester0 commented Jun 6, 2025

No description provided.

@cmester0 cmester0 requested a review from 4ever2 June 6, 2025 14:41
@cmester0 cmester0 changed the base branch from towards-nominals to main June 6, 2025 14:42
@cmester0 cmester0 removed the request for review from 4ever2 June 6, 2025 14:43
@cmester0
Copy link
Collaborator Author

@MarkusKL @spitters These statements should hopefully enable simpler proof structure and thus better automation. We seem to be missing some weakening statement, as ValidPackage now requires the export interface to match exactly.

@cmester0 cmester0 marked this pull request as ready for review June 10, 2025 19:02
ValidPackage L I E2 p →
ValidPackage L I E1 p.
Proof.
Admitted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be able to use id_link to explicitly remove functions from a package. Previously, I have also found a lemma like this useful: P o ID I o P' = P o P' where imports of P are a submap of I, which is a submap of the exports of P'.

Copy link
Collaborator Author

@cmester0 cmester0 Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a valid version of the weakening statement. But if we force E to be the export interface of p, then we could just drop E?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what you need the weakening lemma for, so I cannot say if it is on the right form. Does it apply to any of the examples in this repository?

@4ever2 4ever2 force-pushed the advantage-properties branch from cbc9b7b to 4bcd118 Compare June 16, 2025 14:14
@4ever2 4ever2 added the enhancement New feature or request label Jun 16, 2025
@spitters
Copy link
Contributor

Should be revisited after nominal:
#82

@4ever2 4ever2 force-pushed the advantage-properties branch from 4bcd118 to b1fbf29 Compare November 6, 2025 15:36
@4ever2
Copy link
Collaborator

4ever2 commented Nov 6, 2025

I rebased this on top of the nominal changes.

@MarkusKL most of your comments were addressed. Is there anything more blocking this from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants