fix incorrect work of savepoint#390
Merged
SRombauts merged 1 commit intoSRombauts:masterfrom Dec 15, 2022
Merged
Conversation
…t form sqlite transaction stack.
Owner
|
Thanks for providing this :) I think the main issue is that the old unit test didn't show that there was a bug, and now it doesn't prove either that the bug is fixed. |
Owner
|
OK, I merged it without the unit tests. I should rename the rollback() method to rollbackTo() now that I understand better the differences! Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add release for savepoint after rollabck in destructor for deleting it form sqlite transaction stack.