Add other constants that work with sqlite3_open_v2#305
Merged
SRombauts merged 1 commit intoSRombauts:masterfrom Jan 18, 2021
Merged
Add other constants that work with sqlite3_open_v2#305SRombauts merged 1 commit intoSRombauts:masterfrom
SRombauts merged 1 commit intoSRombauts:masterfrom
Conversation
Owner
|
Thanks for your contribution, I don't know exactly how I didn't merge it when I first saw it, but now it's fixed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the other flags used in the open function to the SQLite namespace for convenience.
I added the ones that are ok to use with the
sqlite3_open_v2function described here https://www.sqlite.org/c3ref/open.html .I didn't add the VFS only flags mentioned here https://www.sqlite.org/c3ref/c_open_autoproxy.html .
I also made sure the comments relating to threading mode used the "multi-thread" and "serialized" terminology used on this page https://www.sqlite.org/threadsafe.html for clarity.
I'm not sure if there was a reason these weren't included but the first thing I wanted to do was open the database in multi-thread mode and I found the flag was missing.
I've not really tested this beyond compiling it and opening a database with the
SQLite::OPEN_NOMUTEXflag, but since this is just declaring some consts I expect the compiler is enough to check it's right.