Add SID (Sovereign Identity) API implementation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add backup operations: export, import, verify - Add seed phrase operations: verify, export - Add guardian management: add, list, remove, accept, decline - Add guardian recovery flow: initiate, approve, status, cancel - Add citizenship application endpoint - Fix endpoint paths to match core API - Add all required TypeScript types for SID features
- Add 22 tests for backup operations (export, import, verify) - Add tests for seed phrase operations (verify, export) - Add tests for guardian management (add, list, remove, accept, decline) - Add tests for guardian recovery flow (initiate, approve, status, cancel) - Add tests for citizenship application - Add error handling tests for HTTP errors - Increase zhtp-api-methods coverage from 47.65% to 59.37% - Increase overall test count from 168 to 190 tests
kmk142789
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan