Avoid duplication and add enumeration#156
Merged
VCLanNguyen merged 2 commits intofeature/frameshift_refactor_v10_03_00from Nov 24, 2025
Merged
Conversation
VCLanNguyen
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an internal PR within the team working on refactoring the timing reference frames for data, release managers can ignore. We will make a final PR once the main branch is ready.
In this PR I've made some small changes to the object files (not the object structure itself) to ensure we don't duplicate the default values and to add an enumerator for frame shift types.
This goes with SBNSoftware/sbndcode#883