Conversation
…bject stores additional information on the CRT T0 tagging of a TPC track. This object is currently filled and used only in icaruscode.
…d (e.g. PCA, start-to-end-vector, kalman filter, others) and one which store the MC truth of the match if available.
…its (ICAUS-like) or crtTracks (SBND-like). Also, added prefix to the variables for future distinction.
|
This pull request is required for this other icaruscode PR: |
|
Hi Francesco, thanks again for producing this object, it is definitely important to have to better bookkeep our matching. SBND actually has both single hit & track matching. I maybe wasn't brilliantly clear offline, my thought was to avoid bloating the size of these objects unnecessarily was to have two objects with names something like:
This is just a thought - I'm happy to go with a single object if you would rather. My worry is the objects would get a fair bit bigger for every match not just for the track ones. |
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I support Henry's suggestion expressed in his review.
In addition, I question the truth matching flag in the object — we can talk about it if you want.
Besides a few suggested changes, ClassVersion must be added begore we can proceed (see the specific comment in classes_def.xml).
… concerns Henry's request, the object naming infos now reflect CRTHitT0TaggingInfo. Following Gianluca's requests, I removed MC truth level info from the CRTHitT0TaggingIngo and moved them into CRTHitT0TaggingTruthInfo, I have also added the appropriate class definitions.
|
@henrylay97 I believe the latest changes should reflect your request. |
00e7ea8 to
451369d
Compare
|
Thanks for the update Francesco - I'm happy with this! |
|
Hi @PetrilloAtWork, could you please take a look at this PR? I believe @francescopoppi has addressed your requested changes and I'll test this now but it'd be great if you could check. Many thanks! |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
@PetrilloAtWork is this ok to merge or does the PR need additional work? Cheers! |
|
@francescopoppi can you resolve these conflicts please? given #124 was merged, some things need to be resolved here (does that PR mean this can be closed?). Thanks! |
|
I actually put the comment in the previous comment... This is old, from the larsoft v9 era |
This new class introduces additional information which can be used when studying CRT tagged tracks. This object wants to be complementary to the anab::T0 object.
I chatted a bit with @henrylay97 to have a class which can be shared also with SBND people. They will update this in the future.