Update GeomScan File and Add check to Ensure is Compatible with current GDML/Flux#691
Conversation
bear-is-asleep
left a comment
There was a problem hiding this comment.
Looks good to me. I can make sure the sbn dependencies are fine
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
My last commit fixed the unit test failure. |
|
Approved |
Update GeomScan file with current GDML/Flux.
Also, adds a cmake test to ensure that the GeomScan file is compatible with the current flux and gdml versions.
This test requires
fhiclpy, which has been added as a ups dependency.Needs
/exp/sbnd/app/users/mdeltutt/sbnd_datato be tagged as new version ofsbnd_data(addedsbnd_data/GENIE/sbnd_rock_maxpathlength_fluxL_gdmlv02_03.xml).Fixes #654, fixes #519.
Description
Please provide a detailed description of the changes this pull request introduces.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?