Add tpcpmt bfm score and chi2 to CAF files#565
Conversation
fjnicolas
left a comment
There was a problem hiding this comment.
Looks good! Any reason to not add the Angle variable to the CAFs as well?
|
@JosiePaton @PetrilloAtWork Does this look ok to you? |
|
trigger build SBNSoftware/sbnobj#144 SBNSoftware/sbnanaobj#156 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
Description
This PR adds new attributes to the TPCPMTBarycenterFM objects to store the chi2 and score that is used to perform matching after the upgrades to the algorithm. (SBNSoftware/sbndcode#807)
This PR is to be merged with
SBNSoftware/sbnanaobj#156