Skip to content

Comments

Updates to Enable ICARUS Spring Production#526

Merged
kjplows merged 19 commits intodevelopfrom
release/Mar25Production
Apr 28, 2025
Merged

Updates to Enable ICARUS Spring Production#526
kjplows merged 19 commits intodevelopfrom
release/Mar25Production

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Mar 24, 2025

This PR makes updates to sbncode necessary to enable the Spring production in ICARUS. It depends on:
SBNSoftware/sbnobj#124
LArSoft/larsim#151
WireCell/wire-cell-toolkit#400 (will need a new cut of WireCell+LArSoft with this in)
SBNSoftware/sbnobj#129

It incorporates (#525), and can be merged in after that one.

In addition to updating the calbiration NTupler, it includes updates to CAFMaker to support overlays (from @icaromx) and updates to the new MergeSimSources module interface in LArSim (from @jzennamo).

It incorporates #535, and can be merged either instead of or after that PR.

@kjplows
Copy link
Contributor

kjplows commented Apr 10, 2025

@grayputnam could you please make the changes needed for larsim/#151 to not fail?
also please add a reviewer, thanks!

@kjplows kjplows moved this from Open pull requests to Urgent checks in SBN software development Apr 18, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 18, 2025

@gputnam I have resolved conflicts as #533 is merged, this should take care of the larsim signature changing. Changed files are as below
image

@kjplows
Copy link
Contributor

kjplows commented Apr 18, 2025

trigger build

@kjplows kjplows requested review from JosiePaton and kjplows April 18, 2025 12:55
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 18, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 18, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 28, 2025

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 28, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 28, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 28, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 28, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 28, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Apr 28, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 28, 2025

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows
Copy link
Contributor

kjplows commented Apr 28, 2025

merging after discussion with @gputnam - icaruscode build fail on CI hypothesised to come from merging of icaruscode/#817

@kjplows kjplows merged commit ec69666 into develop Apr 28, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Apr 28, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Apr 28, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development May 8, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the v10_05_00 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

5 participants