Cleanup to accommodate making ChannelROI objects usable at the SBN level#816
Cleanup to accommodate making ChannelROI objects usable at the SBN level#816
Conversation
…s well the modules converting from Wire to/from ChannelROI. Removing from icaruscode
|
@jzennamo, Could you take a look at this PR? Thanks! |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/icarus_signal_processing/pull#24 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
The gauss hit finder operating on ChannelROIs has moved to sbncode, as well the modules converting from Wire to/from ChannelROI. Removing from icaruscode
Have also added the option to run "GaussHitFinderSBN" which operates from ChannelROI input instead of recob::Wires.