Allow excluding request logs for URI path patterns.#366
Open
KarstenSchnitter wants to merge 3 commits intomainfrom
Open
Allow excluding request logs for URI path patterns.#366KarstenSchnitter wants to merge 3 commits intomainfrom
KarstenSchnitter wants to merge 3 commits intomainfrom
Conversation
Add servlet init parameter `excludePatterns` to configure a comma-separate list of ant-like patterns (wildcards "*" and "**") to exclude uris from request log generation. This can be used to suppress request logs from health or metrics endpoints. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
Add benchmarks to ensure performance of URI filtering. The are executed as part of the Maven verify lifecycle phase when profile benchmark is active. The benchmarks show on my machine, that filtering without wildcards adds no more than 10ns and single wildcard matches no more than 40ns latency. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
All JMH benchmarks now align in the profile benchmark. They can be executed with mvn verify -P benchmark Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #324.
Provides an option to suppress request logs for comma-separated ant-like uri patterns. This allows to disable request log generation for health or monitoring endpoints.
The implementation comes with JMH benchmarks to ensure low latency due to filtering. The logback and log4j2 benchmarks were aligned to the servlet approach.