digest: remove Clone from MacTraits#2341
Merged
Conversation
NOTE: this is a breaking change! We are doing it in spite of `digest` having a stable release as the downstream crates that depend on this functionality have not yet had stable releases, so it should only impact people who are currently relying on prereleases Closes #2329
Member
Author
|
Looks like this will need a companion PR in https://github.com/RustCrypto/MACs |
Member
|
Huh, the fun of circular dependencies... I can prepare |
newpavlov
added a commit
to RustCrypto/MACs
that referenced
this pull request
Mar 12, 2026
Member
|
I merged the |
Member
Author
|
I’m busy for the next few days if you want to edit or recreate this PR |
newpavlov
approved these changes
Mar 13, 2026
This was referenced Mar 13, 2026
Merged
newpavlov
added a commit
that referenced
this pull request
Mar 13, 2026
Note: v0.11.1 was yanked because v0.11.2 introduces minor breaking changes affecting only pre-release versions of downstream crates. ### Changed - Do not implement `Clone` as part of `(Reset)MacTraits` in the `buffer_fixed!` macro ([#2341]) - `EagerHash` trait to be a sub-trait of `Clone` ([#2341]) [#2341]: #2341
newpavlov
added a commit
to RustCrypto/MACs
that referenced
this pull request
Mar 13, 2026
This PR reverts #250 and #253 since the relevant fix was added to `digest` (see RustCrypto/traits#2341).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this is a breaking change! We are doing it in spite of
digesthaving a stable release as the downstream crates that depend on this functionality have not yet had stable releases, so it should only impact people who are currently relying on prereleasesCloses #2329