pbkdf2: make public PBKDF2 Ident values#375
Merged
tarcieri merged 3 commits intoRustCrypto:masterfrom Feb 17, 2023
Merged
Conversation
Member
|
Before exporting these I think we might consider better names that reflect they're Perhaps either adding |
Contributor
Author
|
Thanks for your advice! |
Member
|
Personally I think I'd prefer the inherent constant approach, since it cuts down on the number of exports/imports |
Contributor
Author
|
OK!, so how about making it an intrinsic constant of |
Member
|
That looks good, yes |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For RustCrypto members
Thank you for developing a awesome crate!
I have a question.
Why do the other crates maintained by this repository have published Ident values, but not in
pbkdf2?Looking at the code, it seems that there is an intention to publish it, but it is not available because there is no
usedeclaration.If you just forgot to publish it, I would appreciate it if you could merge this PR and make it available.