pbkdf2: remove default simple feature#336
Merged
Conversation
I suspect that most users of this crate care about the low-level `pbkdf2` API as opposed to the higher-level password hashing API which implements the PHC string format. The `simple` API pulls in quite a few dependencies (to the point I'm encountering dependency conflicts).
Member
Author
|
Here's an example resolution failure I'm encountering via a transitive dependency: |
tarcieri
commented
Aug 29, 2022
| [package] | ||
| name = "pbkdf2" | ||
| version = "0.11.0" | ||
| version = "0.12.0-pre" |
Member
Author
There was a problem hiding this comment.
In addition to this change, I think we're about due for another release of password-hash
Member
Author
|
Sure. I'm in no rush to get another release out, so I think exploring some of the ideas from #335 would be great. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect that most users of this crate care about the low-level
pbkdf2API as opposed to the higher-level password hashing API which implements the PHC string format.The
simpleAPI pulls in quite a few dependencies (to the point I'm encountering dependency conflicts).