const-oid: fallible const parser + ::new_unwrap#458
Merged
Conversation
Member
Author
|
FYI @npmccallum |
8d33af4 to
e745606
Compare
::new_unwrap::new_unwrap
e745606 to
5145a58
Compare
With the introduction of const panic it's now possible to implement a proper fallible parser with `const fn`, eliminating some of the duplication between the `const fn` and fallible code in this crate. Unfortunately it's not yet possible to call `Result::unwrap` in a const context, so instead this commit adds an `ObjectIdentifier::new_unwrap` method which leverages const panic to print the `Result` as best it can. In future versions of Rust, it will be possible to replace this with `ObjectIdentifier::new(...).unwrap()`.
5145a58 to
2d232f4
Compare
npmccallum
approved these changes
Mar 2, 2022
Contributor
npmccallum
left a comment
There was a problem hiding this comment.
Approved, pending tests passing.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of const panic it's now possible to implement a proper fallible parser with
const fn, eliminating some of the duplication between theconst fnand fallible code in this crate.Unfortunately it's not yet possible to call
Result::unwrapin a const context, so instead this commit adds anObjectIdentifier::new_unwrapmethod which leverages const panic to print theResultas best it can.In future versions of Rust, it will be possible to replace this with
ObjectIdentifier::new(...).unwrap().