Conversation
The proc macro previously derived the `Decode` trait, which is not composable with context-specific fields, which depend on the `DecodeValue` trait in order to support IMPLICIT fields. This commit changes the custom derive macro for `Sequence` to produce a `DecodeValue` impl instead of `Decode`. This leverages the newly introduced `SequenceRef` type from #374.
carl-wallace
added a commit
to carl-wallace/formats
that referenced
this pull request
Feb 1, 2022
… Decodable (RustCrypto#375) and remove custom impls on Certificate, NameConstraints and CertPathControls.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proc macro previously derived the
Decodetrait, which is not composable with context-specific fields, which depend on theDecodeValuetrait in order to support IMPLICIT fields.This commit changes the custom derive macro for
Sequenceto produce aDecodeValueimpl instead ofDecode. This leverages the newly introducedSequenceReftype from #374.