Conversation
Adds a `Base64` enum with variants for `Bcrypt`, `Crypt`, and `ShaCrypt`, i.e. the non-standard Base64 variants used in MCF hashes. This is extracted from `password_hash::Encoding` which was straddling the line between the PHC format and MCF with such a feature. That type can now be removed in the next breaking release.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Dec 2, 2025
The encoding types in this crate are designed around the PHC String Format which uses "B64", a.k.a. unpadded non-URL-safe Base64. The `Encoding` type was designed to make it possible to use alternative encodings from Modular Crypt Format (MCF), but that doesn't actually make sense because PHC Strings mandate "B64". The `Encoding` type has since been extracted into the `mcf` crate as `mcf::Base64`: RustCrypto/formats#1918
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Dec 2, 2025
The encoding types in this crate are designed around the PHC String Format which uses "B64", a.k.a. unpadded non-URL-safe Base64. The `Encoding` type was designed to make it possible to use alternative encodings from Modular Crypt Format (MCF), but that doesn't actually make sense because PHC Strings mandate "B64". The `Encoding` type has since been extracted into the `mcf` crate as `mcf::Base64`: RustCrypto/formats#1918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Base64enum with variants forBcrypt,Crypt, andShaCrypt, i.e. the non-standard Base64 variants used in MCF hashes.This is extracted from
password_hash::Encodingwhich was straddling the line between the PHC format and MCF with such a feature. That type can now be removed in the next breaking release.