aes: consolidate backend configuration under aes_backend#541
Open
aes: consolidate backend configuration under aes_backend#541
aes_backend#541Conversation
Consolidates the previous `cfg` options `aes_force_soft`, `aes_avx256`, and `aes_avx512` as `aes_backend` values: - `avx256` - `avx512` - `soft` The `aes_compact` option has been retained as-is so it can be used in conjunction with the other options, though perhaps we can find some other solution for it. This does have the effect of preventing `avx256` and `avx512` from being simultaneously enabled, although I'm not sure that would ever actually make sense?
9078256 to
f0f6354
Compare
newpavlov
approved these changes
Mar 10, 2026
Member
newpavlov
left a comment
There was a problem hiding this comment.
Maybe rename aes_compact to something like aes_soft_compact since it only affects the software backend?
| //! You can modify crate using the following configuration flags: | ||
| //! | ||
| //! - `aes_force_soft`: force software implementation. | ||
| //! - `aes_backend = "soft"`: force software implementation. |
Member
There was a problem hiding this comment.
This entry should list all supported values for aes_backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the previous
cfgoptionsaes_force_soft,aes_avx256, andaes_avx512asaes_backendvalues:avx256avx512softThe
aes_compactoption has been retained as-is so it can be used in conjunction with the other options, though perhaps we can find some other solution for it.This does have the effect of preventing
avx256andavx512from being simultaneously enabled, although I'm not sure that would ever actually make sense?