Skip to content

aes: add #[inline] attributes for KeyInit::new impls#386

Merged
newpavlov merged 1 commit intomasterfrom
aes_inline
Sep 25, 2023
Merged

aes: add #[inline] attributes for KeyInit::new impls#386
newpavlov merged 1 commit intomasterfrom
aes_inline

Conversation

@newpavlov
Copy link
Member

Fixes #385

@tarcieri
Copy link
Member

This has no effect on #385:

   Compiling aes v0.8.3 (https://github.com/RustCrypto/block-ciphers.git?branch=aes_inline#a8bbd2f9)
[...]
[stack]: 8388608 bytes
4001893a10  40 40 40 40 40 40 40 40  40 40 40 40 40 40 40 40   !!!!!!!!!!!!!!!!
4001893a20  40 40 40 40 40 40 40 40  40 40 40 40 40 40 40 40   !!!!!!!!!!!!!!!!
4001893b10  40 40 40 40 40 40 40 40  40 40 40 40 40 40 40 40   !!!!!!!!!!!!!!!!
4001893b20  40 40 40 40 40 40 40 40  40 40 40 40 40 40 40 40   !!!!!!!!!!!!!!!!
4001893dc0  40 40 40 40 40 40 40 40  40 40 40 40 40 40 40 40   !!!!!!!!!!!!!!!!
[...]

FWIW I tried something similar in https://github.com/RustCrypto/block-ciphers/tree/aes/armv8-keep-key-schedule-off-stack

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, this is probably still worth merging.

@newpavlov newpavlov merged commit 2783505 into master Sep 25, 2023
@newpavlov newpavlov deleted the aes_inline branch September 25, 2023 22:45
@newpavlov newpavlov mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aes: zeroize not fully removing key schedule from memory?

2 participants