Conversation
Member
tarcieri
commented
Feb 7, 2021
- Uses array operations on the block buffer
- Uses loops where they don't appear to impact performance
- Uses array operations on the block buffer - Uses loops where they don't appear to impact performance
63375b1 to
87e8aab
Compare
Member
Author
|
Note: I haven't systematically determined this doesn't change the generated assembly. Preliminary benchmarking shows negligible impact. |
tarcieri
commented
Feb 7, 2021
Comment on lines
+3
to
+4
| // TODO(tarcieri): check performance impact / generated assembly changes | ||
| #![allow(clippy::needless_range_loop)] |
Member
Author
There was a problem hiding this comment.
Strangely clippy's suggested refactoring seemed to negatively impact performance?(!)
Member
There was a problem hiding this comment.
Yeah, I've seen such behavior as well. Iterator based code probably makes it harder for LLVM to unroll the loops. Also subjectively, I think for such loops range loops result in a better, easier to understand code.
newpavlov
approved these changes
Feb 7, 2021
newpavlov
reviewed
Feb 7, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.