fix: handle odd keys#459
Merged
Merged
Conversation
Member
|
I’m reminded of #445 |
Member
Author
|
yes, but the goal here is not general security, but rather for a first step remove unusable keys once we have a solution for #445 this can be folded in |
Otherwise the inner precompute could fail
ff9cff3 to
5f92176
Compare
Member
Author
|
already published on the |
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Ther are two issues with oddly formed keys that were not properly handled - avoid using `-` to avoid a subtraction with overflow for pkcs - always validate the key in `from_components` to avoid errors in the internal `precompute`
tarcieri
pushed a commit
that referenced
this pull request
Jan 27, 2026
Adds a `hazmat`-gated method to `RsaPrivateKey` to allow construction of keys with large public exponents, which was removed in #459. These are a potential DoS vector ("RSADoS") hence gating on `hazmat`: https://www.imperialviolet.org/2012/03/17/rsados.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ther are two issues with oddly formed keys that were not properly handled
-to avoid a subtraction with overflow for pkcsfrom_componentsto avoid errors in the internalprecompute