Fix possible panic in internals::left_pad#262
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Feb 10, 2023
Merged
Conversation
tarcieri
approved these changes
Feb 10, 2023
dignifiedquire
approved these changes
Feb 10, 2023
Merged
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Co-authored-by: Diego Fabregat Traver <diego.fabregat@rwth-aachen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents potential panics in internals::left_pad when the requested padded length is smaller than the input length. It also removes related dead-code in the implementation of EncryptionPrimitive for RsaPublicKey (when not panicking, the returned vector was always of length pad_size).
Feedback welcome :)