Skip to content

Delete task confirmation enhancements#1245

Merged
cte merged 1 commit intomainfrom
cte/delete-confirmation-enhancements
Feb 28, 2025
Merged

Delete task confirmation enhancements#1245
cte merged 1 commit intomainfrom
cte/delete-confirmation-enhancements

Conversation

@cte
Copy link
Copy Markdown
Collaborator

@cte cte commented Feb 27, 2025

Description

Some things that were bugging me:

  • The confirmation wasn't appearing when clicking "Delete" from the task header (arguably a more important place to confirm than the history list).
  • The escape key wasn't closing the confirmation.
  • The enter key wasn't triggering a delete.
Screenshot 2025-02-27 110843

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Enhances task deletion confirmation with a dialog, keyboard shortcuts, and Shift+Click support in TaskHeader.tsx and HistoryView.tsx.

  • Behavior:
    • Adds confirmation dialog for task deletion in TaskHeader.tsx and HistoryView.tsx.
    • Supports immediate deletion with Shift+Click.
    • Escape key closes dialog; Enter key confirms deletion.
  • Components:
    • Updates DeleteTaskDialog to handle Enter key for deletion and Escape key for closing.
    • Refactors TaskActions in TaskHeader.tsx to include confirmation logic.
  • Tests:
    • Adds tests in HistoryView.test.tsx for confirmation dialog and Shift+Click behavior.

This description was created by Ellipsis for 21fed4c. It will automatically update as commits are pushed.

@cte cte requested a review from mrubens as a code owner February 27, 2025 19:11
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 21fed4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 27, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2025
@cte cte force-pushed the cte/delete-confirmation-enhancements branch 2 times, most recently from a8a9ffb to bb9c6da Compare February 28, 2025 05:35
@cte cte force-pushed the cte/delete-confirmation-enhancements branch from 55c30da to 21fed4c Compare February 28, 2025 06:26
@cte cte merged commit b6a9bc9 into main Feb 28, 2025
9 checks passed
@cte cte deleted the cte/delete-confirmation-enhancements branch February 28, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants