Conversation
🦋 Changeset detectedLatest commit: 41e75bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
275cf28 to
241be7f
Compare
88883ea to
2e93a2e
Compare
webview-ui/src/utils/validate.ts
Outdated
There was a problem hiding this comment.
Repeated error messages (e.g. 'You must provide a valid API key.') appear for several providers. Consider extracting these strings into constants or a helper so that updates and translations are centralized.
There was a problem hiding this comment.
Intentionally leaving these console.log in (but commented out) for a future refactor.
There was a problem hiding this comment.
The class 'focus:outline-hidden' appears to be a typo. It is likely meant to be 'focus:outline-none' to properly remove the outline on focus.
| <DialogPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4"> | |
| <DialogPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-none disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4"> |
124e2c1 to
41e75bc
Compare
| )} | ||
| {...props}> | ||
| {children} | ||
| <DialogPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4"> |
There was a problem hiding this comment.
Typographical Issue: The class name 'focus:outline-hidden' on line 48 appears to be a typo. It likely should be 'focus:outline-none' to correctly remove the focus outline. Please update this class accordingly.
| <DialogPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4"> | |
| <DialogPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-none disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4"> |
Description
Several fixes:
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
Fixes and enhances the model picker functionality, UI consistency, and error handling in the settings interface.
ClineProviderandApiOptions.SettingsView.ApiOptions.ModelPicker.ThinkingBudget.ApiErrorMessageto be more concise and reusable.DialogandAlertDialogcomponents for better maintainability.validateApiConfigurationandvalidateModelIdto includerequestyprovider checks.This description was created by
for 41e75bc. It will automatically update as commits are pushed.