Skip to content

Fix stdin-stream cancel race and add integration test suite#11817

Merged
cte merged 1 commit intomainfrom
codex/stdin-stream-integration-and-cancel-race-fix
Mar 2, 2026
Merged

Fix stdin-stream cancel race and add integration test suite#11817
cte merged 1 commit intomainfrom
codex/stdin-stream-integration-and-cancel-race-fix

Conversation

@cte
Copy link
Copy Markdown
Collaborator

@cte cte commented Mar 2, 2026

Summary

  • fix stdin-stream request attribution and queue promotion handling for follow-up messages in apps/cli/src/commands/cli/stdin-stream.ts
  • harden cancel behavior in src/core/webview/ClineProvider.ts so startup-time cancel does not fail when task history is not persisted yet
  • fix attempt-completion follow-up routing in src/core/tools/AttemptCompletionTool.ts
  • replace ad-hoc stdin repro scripts with a reusable integration runner in apps/cli/scripts/integration
  • rename CLI integration command to pnpm test:integration

Integration coverage added

  • cancel-active-task
  • cancel-immediately-after-start-ack
  • followup-after-completion
  • followup-during-streaming
  • message-without-active-task
  • multi-message-queue-order
  • shutdown-while-running
  • start-while-busy

Validation

  • npx pnpm --dir apps/cli build:extension
  • npx pnpm --dir apps/cli exec tsc --noEmit --pretty false
  • npx pnpm --dir apps/cli test:integration (8/8 passed)
  • pre-push check-types also passed via repo hooks

Interactively review PR in Roo Code Cloud

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug Something isn't working labels Mar 2, 2026
@cte cte merged commit e6ad794 into main Mar 2, 2026
13 of 14 checks passed
@cte cte deleted the codex/stdin-stream-integration-and-cancel-race-fix branch March 2, 2026 06:27
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Mar 2, 2026
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant