Skip to content

Improvement/task delete confirmation 854#1100

Merged
cte merged 5 commits intoRooCodeInc:mainfrom
mosleyit:improvement/task_delete_confirmation_854
Feb 24, 2025
Merged

Improvement/task delete confirmation 854#1100
cte merged 5 commits intoRooCodeInc:mainfrom
mosleyit:improvement/task_delete_confirmation_854

Conversation

@emshvac
Copy link
Copy Markdown
Contributor

@emshvac emshvac commented Feb 21, 2025 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testing no failing unit tests

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

image
--edit to show corrected image

Related Issues

Fixes #854

Reviewers

Important

Adds a confirmation dialog in deleteTaskWithId() in ClineProvider.ts to confirm task deletion.

  • Behavior:
    • Adds a confirmation dialog in deleteTaskWithId() in ClineProvider.ts to confirm task deletion.
    • If user selects "Delete", the task is deleted; otherwise, the operation is canceled.

This description was created by Ellipsis for 2fd3431. It will automatically update as commits are pushed.

@emshvac
Prevents accidental task deletions by requiring explicit user confirm…
6a29a8b 
…ation through a modal dialog. This improves the user experience by adding a safety check before performing irreversible actions.
@emshvac
no duplicated cancel button
2fd3431
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1922b8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emshvac emshvac marked this pull request as ready for review February 21, 2025 01:09
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working Enhancement New feature or request labels Feb 21, 2025
@hannesrudolph
Copy link
Copy Markdown
Collaborator

hannesrudolph commented Feb 21, 2025

Can you switch to a Radix UI Dialog Modal instead of the VScode native modal?

@emshvac
This commit replaces the VSCode native dialog with a Radix AlertDialo…
5a43f86 
…g component for task deletion confirmation. The change provides a more consistent user experience by using the same design system as the rest of the application.

Changes:

Add new DeleteTaskDialog component using Radix UIs AlertDialog
Update HistoryView to manage dialog state and task deletion flow
Remove VSCode native dialog from ClineProvider.ts
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 21, 2025
@emshvac
Copy link
Copy Markdown
Contributor Author

emshvac commented Feb 21, 2025

Per @hannesrudolph request this has been moved to us Radix UI Alert Dialog to fit the project structure better

@hannesrudolph
Copy link
Copy Markdown
Collaborator

hannesrudolph commented Feb 21, 2025

Per @hannesrudolph request this has been moved to us Radix UI Alert Dialog to fit the project structure better

Can you update the pic in the PR?

@emshvac
Copy link
Copy Markdown
Contributor Author

emshvac commented Feb 21, 2025

@hannesrudolph that is complete. Sorry for the oversite.

@hannesrudolph
Copy link
Copy Markdown
Collaborator

hannesrudolph commented Feb 21, 2025

Beautiful @mrubens take a look when you get a chance!

mrubens
mrubens approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 21, 2025
@mrubens
Copy link
Copy Markdown
Collaborator

mrubens commented Feb 21, 2025

Looks like a test failure though

@emshvac
Copy link
Copy Markdown
Contributor Author

emshvac commented Feb 23, 2025

Test needs to handle the delete confirmation. Will update

@mosleyit
Copy link
Copy Markdown
Contributor

mosleyit commented Feb 24, 2025

@mrubens corrected mistake in unit test. Ready to merge upon your approval.

@cte cte merged commit 656ab2f into RooCodeInc:main Feb 24, 2025
9 checks passed
@atlasgong atlasgong mentioned this pull request Feb 28, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens mrubens approved these changes

@stea9499 stea9499 Awaiting requested review from stea9499

@ColemanRoo ColemanRoo Awaiting requested review from ColemanRoo

@cte cte Awaiting requested review from cte cte is a code owner

Assignees

No one assigned

Labels

bug Something isn't working Enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No delete confirmation

5 participants

@emshvac @hannesrudolph @mrubens @mosleyit @cte