chore: fix bundle not including local deps

[sampaiodiego]

Summary by CodeRabbit

• New Features

  • None

• Bug Fixes

  • Excludes locally managed packages from the dependency list, preventing duplicate entries and conflicts. Results in cleaner outputs and more reliable builds.

• Chores

  • Internal housekeeping for future improvements to package discovery (no user-facing changes).

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a localPackages set in bundle.ts to capture names of known packages during dependency collection and filters the final dependency list to exclude those local packages. Existing logic for aggregating dependencies across packages remains unchanged. A TODO notes future work to read folders from the packages directory.

Changes

Cohort / File(s)	Summary
Dependency collection refinement .../bundle.ts	Introduces localPackages to record known package names; during collection, adds each package’s name to this set and filters out dependencies that match localPackages. Adds a TODO to read package folders dynamically. No exported/public API signature changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant B as Bundle (bundle.ts)
  participant P as Packages
  participant DC as DependencyCollector

  Note over B,P: Start dependency aggregation
  B->>P: Iterate known packages
  loop For each package
    P-->>B: package info (name, deps)
    B->>B: Add package.name to localPackages
    B->>DC: Collect deps from package
    DC-->>B: dependency list
  end

  Note over B: Build consolidated dependency list
  B->>B: Filter out deps in localPackages
  B-->>B: Final external dependency list

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• chore: implement bundle script #219 — Also modifies bundle.ts dependency collection by introducing localPackages and filtering workspace packages; appears directly related to this change.

Suggested reviewers

• ggazzo

Poem

In bundles I hop, with careful care,
I sift out friends who already live there.
Local names stay snug in the burrow’s keep,
External carrots are all that I reap.
Thump-thump—clean lists, tidy as can be! 🥕🐇

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-bundle-internal-deps

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4a295fa and b610d08.

📒 Files selected for processing (1)

• bundle.ts (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.07%. Comparing base (4a295fa) to head (b610d08).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          63       63           
  Lines        4719     4719           
=======================================
  Hits         3826     3826           
  Misses        893      893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.