Skip to content

chore(deps): bump xmldom and related deps#40370

Merged
julio-rocketchat merged 2 commits into
release-8.4.1from
backport-8.4.1-40270
May 3, 2026
Merged

chore(deps): bump xmldom and related deps#40370
julio-rocketchat merged 2 commits into
release-8.4.1from
backport-8.4.1-40270

Conversation

@dionisio-bot

@dionisio-bot dionisio-bot Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Backport of #40270

@dionisio-bot dionisio-bot Bot requested a review from a team as a code owner May 3, 2026 12:32
@dionisio-bot dionisio-bot Bot requested a review from julio-rocketchat May 3, 2026 12:32
@changeset-bot

changeset-bot Bot commented May 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4557508

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot Bot added the backport Used to inform backported PR label May 3, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/app/meteor-accounts-saml/server/lib/parsers/Response.ts">

<violation number="1" location="apps/meteor/app/meteor-accounts-saml/server/lib/parsers/Response.ts:213">
P1: This hard-codes decryption to allow insecure XML encryption algorithms, weakening the v4 security default for every SAML response.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread apps/meteor/app/meteor-accounts-saml/server/lib/parsers/Response.ts
@codecov

codecov Bot commented May 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.99%. Comparing base (b05e5d0) to head (4557508).
⚠️ Report is 1 commits behind head on release-8.4.1.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.4.1   #40370      +/-   ##
=================================================
- Coverage          69.99%   69.99%   -0.01%     
=================================================
  Files               3299     3299              
  Lines             120261   120261              
  Branches           21549    21513      -36     
=================================================
- Hits               84180    84172       -8     
- Misses             32798    32799       +1     
- Partials            3283     3290       +7     
Flag Coverage Δ
e2e 59.65% <ø> (+<0.01%) ⬆️
e2e-api 47.11% <ø> (+0.05%) ⬆️
unit 70.80% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dionisio-bot

dionisio-bot Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@julio-rocketchat julio-rocketchat merged commit daacbd1 into release-8.4.1 May 3, 2026
47 checks passed
@julio-rocketchat julio-rocketchat deleted the backport-8.4.1-40270 branch May 3, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant