chore: re-enable linting in apps-engine

eslint.config.mjs

@@ -289,14 +289,10 @@ export default [
 		},
 	},
 	{
-		files: ['packages/apps-engine/**/*.ts'],
-		languageOptions: {
-			parserOptions: {
-				project: getAbsolutePath('./packages/apps-engine/tsconfig-lint.json'),
-			},
-		},
+		files: ['packages/apps-engine/**/*'],
 		rules: {
 			'@typescript-eslint/no-empty-object-type': 'off',
+			'@typescript-eslint/no-unnecessary-type-assertion': 'off', // this rule does not deal well with assertions that remove `undefined` from the type
 			'@typescript-eslint/no-unsafe-function-type': 'error',
 			'@typescript-eslint/no-wrapper-object-types': 'error',
 			'@typescript-eslint/naming-convention': [
@@ -342,7 +338,14 @@ export default [
 		},
 	},
 	{
-		ignores: ['packages/apps-engine/**/@(client|definition|docs|server|lib|deno-runtime|.deno|.deno-cache)/**'],
+		files: ['packages/apps-engine/tests/**/*'],
+		rules: {
+			'@typescript-eslint/no-non-null-assertion': 'off',
+			'testing-library/no-await-sync-queries': 'off',
+		},
+	},
+	{
+		ignores: ['packages/apps-engine/@(client|definition|docs|server|lib|deno-runtime|.deno|.deno-cache)'],
 	},
 	{
 		files: ['packages/core-typings/**/*'],

packages/apps-engine/src/client/AppsEngineUIClient.ts

@@ -7,7 +7,7 @@ import { randomString } from './utils';
  * Represents the SDK provided to the external component.
  */
 export class AppsEngineUIClient {
-	private listener: (this: Window, ev: MessageEvent) => any;
+	private listener: (this: Window, ev: MessageEvent<{ [MESSAGE_ID]?: { id: string; payload: any } }>) => void;
 
 	private callbacks: Map<string, (response: any) => any>;
 
@@ -39,7 +39,7 @@ export class AppsEngineUIClient {
 	 */
 	public init(): void {
 		this.listener = ({ data }) => {
-			if (!data?.hasOwnProperty(MESSAGE_ID)) {
+			if (!data?.[MESSAGE_ID]) {
 				return;
 			}
 

packages/apps-engine/src/client/AppsEngineUIHost.ts

@@ -21,8 +21,8 @@ export abstract class AppsEngineUIHost {
 	 * initialize the AppClientUIHost by registering window `message` listener
 	 */
 	public initialize() {
-		window.addEventListener('message', async ({ data, source }) => {
-			if (!data?.hasOwnProperty(MESSAGE_ID)) {
+		window.addEventListener('message', ({ data, source }) => {
+			if (!data?.[MESSAGE_ID]) {
 				return;
 			}
 
@@ -34,10 +34,10 @@ export abstract class AppsEngineUIHost {
 
 			switch (action) {
 				case AppsEngineUIMethods.GET_USER_INFO:
-					this.handleAction(action, id, await this.getClientUserInfo());
+					void this.getClientUserInfo().then((userInfo) => this.handleAction(action, id, userInfo));
 					break;
 				case AppsEngineUIMethods.GET_ROOM_INFO:
-					this.handleAction(action, id, await this.getClientRoomInfo());
+					void this.getClientRoomInfo().then((roomInfo) => this.handleAction(action, id, roomInfo));
 					break;
 			}
 		});

packages/apps-engine/src/client/definition/index.ts

@@ -1,4 +1,4 @@
 export * from './AppsEngineUIMethods';
-export * from './IExternalComponentUserInfo';
-export * from './IExternalComponentRoomInfo';
-export * from './IAppsEngineUIResponse';
+export type * from './IExternalComponentUserInfo';
+export type * from './IExternalComponentRoomInfo';
+export type * from './IAppsEngineUIResponse';

packages/apps-engine/src/definition/App.ts

@@ -39,7 +39,7 @@ export abstract class App implements IApp {
 			`Created by ${this.info.author.name}`,
 		);
 
-		this.setStatus(AppStatus.CONSTRUCTED);
+		void this.setStatus(AppStatus.CONSTRUCTED);
 	}
 
 	public async getStatus(): Promise<AppStatus> {
@@ -141,6 +141,10 @@ export abstract class App implements IApp {
 	}
 
 	public getAccessors(): IAppAccessors {
+		if (!this.accessors) {
+			throw new Error('Accessors not initialized');
+		}
+
 		return this.accessors;
 	}
 

packages/apps-engine/src/definition/accessors/ILivechatCreator.ts

@@ -16,7 +16,10 @@ export interface ILivechatCreator {
 	 * @param contactData Optional contact data for fallback lookup. Use `{ phone: '+1234567890' }` or `{ email: 'user@example.com' }`
 	 * @returns The visitor if found, undefined otherwise
 	 */
-	resolveVisitor(externalId: Omit<IVisitorExternalIdentifier, 'appId'>, contactData?: ResolveVisitorContactData): Promise<IVisitor | undefined>;
+	resolveVisitor(
+		externalId: Omit<IVisitorExternalIdentifier, 'appId'>,
+		contactData?: ResolveVisitorContactData,
+	): Promise<IVisitor | undefined>;
 	/**
 	 * Creates a room to connect the `visitor` to an `agent`.
 	 *

packages/apps-engine/src/definition/accessors/ILivechatUpdater.ts

@@ -41,8 +41,5 @@ export interface ILivechatUpdater {
 	 *
 	 * @returns Promise resolving to the updated visitor, or undefined if not found
 	 */
-	updateVisitorExternalId(
-		visitorId: string,
-		externalId: Omit<IVisitorExternalIdentifier, 'appId'>,
-	): Promise<IVisitor | undefined>;
+	updateVisitorExternalId(visitorId: string, externalId: Omit<IVisitorExternalIdentifier, 'appId'>): Promise<IVisitor | undefined>;
 }

packages/apps-engine/src/definition/accessors/IRoleRead.ts

@@ -12,7 +12,7 @@ export interface IRoleRead {
 	 * @returns null if no role is found.
 	 * @throws If there is an error while retrieving the role.
 	 */
-	getOneByIdOrName(idOrName: IRole['id'] | IRole['name'], appId: string): Promise<IRole | null>;
+	getOneByIdOrName(idOrName: string, appId: string): Promise<IRole | null>;
 
 	/**
 	 * Retrieves all custom roles.

packages/apps-engine/src/definition/accessors/index.ts

@@ -1,60 +1,60 @@
-export * from './IApiExtend';
-export * from './IAppAccessors';
-export * from './IAppInstallationContext';
-export * from './IAppUpdateContext';
-export * from './IAppUninstallationContext';
-export * from './ICloudWorkspaceRead';
-export * from './IConfigurationExtend';
-export * from './IConfigurationModify';
-export * from './IDiscussionBuilder';
-export * from './IEnvironmentalVariableRead';
-export * from './IEnvironmentRead';
-export * from './IEnvironmentWrite';
-export * from './IExternalComponentsExtend';
-export * from './IExperimentalRead';
+export type * from './IApiExtend';
+export type * from './IAppAccessors';
+export type * from './IAppInstallationContext';
+export type * from './IAppUpdateContext';
+export type * from './IAppUninstallationContext';
+export type * from './ICloudWorkspaceRead';
+export type * from './IConfigurationExtend';
+export type * from './IConfigurationModify';
+export type * from './IDiscussionBuilder';
+export type * from './IEnvironmentalVariableRead';
+export type * from './IEnvironmentRead';
+export type * from './IEnvironmentWrite';
+export type * from './IExternalComponentsExtend';
+export type * from './IExperimentalRead';
 export * from './IHttp';
-export * from './ILivechatCreator';
-export * from './ILivechatMessageBuilder';
-export * from './ILivechatRead';
-export * from './ILivechatUpdater';
+export type * from './ILivechatCreator';
+export type * from './ILivechatMessageBuilder';
+export type * from './ILivechatRead';
+export type * from './ILivechatUpdater';
 export * from './ILogEntry';
-export * from './ILogger';
-export * from './IMessageBuilder';
-export * from './IMessageExtender';
-export * from './IMessageRead';
-export * from './IMessageUpdater';
-export * from './IModify';
-export * from './IModifyCreator';
-export * from './IModifyDeleter';
-export * from './IModifyExtender';
-export * from './IModifyUpdater';
+export type * from './ILogger';
+export type * from './IMessageBuilder';
+export type * from './IMessageExtender';
+export type * from './IMessageRead';
+export type * from './IMessageUpdater';
+export type * from './IModify';
+export type * from './IModifyCreator';
+export type * from './IModifyDeleter';
+export type * from './IModifyExtender';
+export type * from './IModifyUpdater';
 export * from './INotifier';
-export * from './IPersistence';
-export * from './IPersistenceRead';
-export * from './IRead';
-export * from './IRoleRead';
-export * from './IRoomBuilder';
-export * from './IRoomExtender';
-export * from './IRoomRead';
-export * from './ISchedulerExtend';
-export * from './ISchedulerModify';
-export * from './IServerSettingRead';
-export * from './IServerSettingsModify';
-export * from './IServerSettingUpdater';
-export * from './ISettingRead';
-export * from './ISettingsExtend';
-export * from './ISettingUpdater';
-export * from './ISlashCommandsExtend';
-export * from './ISlashCommandsModify';
-export * from './IUIController';
-export * from './IUIExtend';
-export * from './IUploadCreator';
-export * from './IUploadRead';
-export * from './IUserBuilder';
-export * from './IUserRead';
-export * from './IVideoConferenceBuilder';
-export * from './IVideoConferenceExtend';
-export * from './IVideoConferenceRead';
-export * from './IVideoConfProvidersExtend';
-export * from './IModerationModify';
-export * from './IOutboundCommunicationProviderExtend';
+export type * from './IPersistence';
+export type * from './IPersistenceRead';
+export type * from './IRead';
+export type * from './IRoleRead';
+export type * from './IRoomBuilder';
+export type * from './IRoomExtender';
+export type * from './IRoomRead';
+export type * from './ISchedulerExtend';
+export type * from './ISchedulerModify';
+export type * from './IServerSettingRead';
+export type * from './IServerSettingsModify';
+export type * from './IServerSettingUpdater';
+export type * from './ISettingRead';
+export type * from './ISettingsExtend';
+export type * from './ISettingUpdater';
+export type * from './ISlashCommandsExtend';
+export type * from './ISlashCommandsModify';
+export type * from './IUIController';
+export type * from './IUIExtend';
+export type * from './IUploadCreator';
+export type * from './IUploadRead';
+export type * from './IUserBuilder';
+export type * from './IUserRead';
+export type * from './IVideoConferenceBuilder';
+export type * from './IVideoConferenceExtend';
+export type * from './IVideoConferenceRead';
+export type * from './IVideoConfProvidersExtend';
+export type * from './IModerationModify';
+export type * from './IOutboundCommunicationProviderExtend';

packages/apps-engine/src/definition/api/index.ts

@@ -1,8 +1,10 @@
 export { ApiEndpoint } from './ApiEndpoint';
-export { IApi, ApiVisibility, ApiSecurity } from './IApi';
-export { IApiEndpoint } from './IApiEndpoint';
-export { IApiEndpointInfo } from './IApiEndpointInfo';
-export { IApiExample, example } from './IApiExample';
-export { IApiRequest } from './IRequest';
-export { IApiResponse } from './IResponse';
-export { IApiEndpointMetadata } from './IApiEndpointMetadata';
+export type { IApi } from './IApi';
+export { ApiVisibility, ApiSecurity } from './IApi';
+export type { IApiEndpoint } from './IApiEndpoint';
+export type { IApiEndpointInfo } from './IApiEndpointInfo';
+export type { IApiExample } from './IApiExample';
+export { example } from './IApiExample';
+export type { IApiRequest } from './IRequest';
+export type { IApiResponse } from './IResponse';
+export type { IApiEndpointMetadata } from './IApiEndpointMetadata';

packages/apps-engine/src/definition/assets/index.ts

@@ -1,4 +1,4 @@
-import { IAsset } from './IAsset';
-import { IAssetProvider } from './IAssetProvider';
+import type { IAsset } from './IAsset';
+import type { IAssetProvider } from './IAssetProvider';
 
-export { IAsset, IAssetProvider };
+export type { IAsset, IAssetProvider };

packages/apps-engine/src/definition/email/index.ts

@@ -1,4 +1,4 @@
-export * from './IEmailDescriptor';
-export * from './IPreEmailSent';
-export * from './IPreEmailSentContext';
-export * from './IEmail';
+export type * from './IEmailDescriptor';
+export type * from './IPreEmailSent';
+export type * from './IPreEmailSentContext';
+export type * from './IEmail';

packages/apps-engine/src/definition/externalComponent/index.ts

@@ -1,5 +1,5 @@
-import { IExternalComponent } from './IExternalComponent';
-import { IPostExternalComponentClosed } from './IPostExternalComponentClosed';
-import { IPostExternalComponentOpened } from './IPostExternalComponentOpened';
+import type { IExternalComponent } from './IExternalComponent';
+import type { IPostExternalComponentClosed } from './IPostExternalComponentClosed';
+import type { IPostExternalComponentOpened } from './IPostExternalComponentOpened';
 
-export { IExternalComponent, IPostExternalComponentClosed, IPostExternalComponentOpened };
+export type { IExternalComponent, IPostExternalComponentClosed, IPostExternalComponentOpened };

packages/apps-engine/src/definition/livechat/ILivechatRoom.ts

@@ -76,5 +76,5 @@ export const isLivechatRoom = (room: IRoom): room is ILivechatRoom => {
 	return room.type === RoomType.LIVE_CHAT;
 };
 export const isLivechatFromApp = (room: ILivechatRoom): room is ILivechatRoom & { source: IOmnichannelSourceApp } => {
-	return room.source && room.source.type === 'app';
+	return room.source?.type === 'app';
 };

packages/apps-engine/src/definition/livechat/index.ts

@@ -1,26 +1,27 @@
-import { IDepartment } from './IDepartment';
-import { ILivechatContact } from './ILivechatContact';
-import { ILivechatEventContext } from './ILivechatEventContext';
-import { ILivechatMessage } from './ILivechatMessage';
-import { ILivechatRoom } from './ILivechatRoom';
-import { ILivechatRoomClosedHandler } from './ILivechatRoomClosedHandler';
-import { ILivechatTransferData } from './ILivechatTransferData';
-import { ILivechatTransferEventContext, LivechatTransferEventType } from './ILivechatTransferEventContext';
-import { IPostLivechatAgentAssigned } from './IPostLivechatAgentAssigned';
-import { IPostLivechatAgentUnassigned } from './IPostLivechatAgentUnassigned';
-import { IPostLivechatDepartmentDisabled } from './IPostLivechatDepartmentDisabled';
-import { IPostLivechatDepartmentRemoved } from './IPostLivechatDepartmentRemoved';
-import { IPostLivechatGuestSaved } from './IPostLivechatGuestSaved';
-import { IPostLivechatRoomClosed } from './IPostLivechatRoomClosed';
-import { IPostLivechatRoomSaved } from './IPostLivechatRoomSaved';
-import { IPostLivechatRoomStarted } from './IPostLivechatRoomStarted';
-import { IPostLivechatRoomTransferred } from './IPostLivechatRoomTransferred';
-import { IPreLivechatRoomCreatePrevent } from './IPreLivechatRoomCreatePrevent';
-import { IVisitorExternalIdentifier, IVisitor, ResolveVisitorContactData } from './IVisitor';
-import { IVisitorEmail } from './IVisitorEmail';
-import { IVisitorPhone } from './IVisitorPhone';
+import type { IDepartment } from './IDepartment';
+import type { ILivechatContact } from './ILivechatContact';
+import type { ILivechatEventContext } from './ILivechatEventContext';
+import type { ILivechatMessage } from './ILivechatMessage';
+import type { ILivechatRoom } from './ILivechatRoom';
+import type { ILivechatRoomClosedHandler } from './ILivechatRoomClosedHandler';
+import type { ILivechatTransferData } from './ILivechatTransferData';
+import type { ILivechatTransferEventContext } from './ILivechatTransferEventContext';
+import { LivechatTransferEventType } from './ILivechatTransferEventContext';
+import type { IPostLivechatAgentAssigned } from './IPostLivechatAgentAssigned';
+import type { IPostLivechatAgentUnassigned } from './IPostLivechatAgentUnassigned';
+import type { IPostLivechatDepartmentDisabled } from './IPostLivechatDepartmentDisabled';
+import type { IPostLivechatDepartmentRemoved } from './IPostLivechatDepartmentRemoved';
+import type { IPostLivechatGuestSaved } from './IPostLivechatGuestSaved';
+import type { IPostLivechatRoomClosed } from './IPostLivechatRoomClosed';
+import type { IPostLivechatRoomSaved } from './IPostLivechatRoomSaved';
+import type { IPostLivechatRoomStarted } from './IPostLivechatRoomStarted';
+import type { IPostLivechatRoomTransferred } from './IPostLivechatRoomTransferred';
+import type { IPreLivechatRoomCreatePrevent } from './IPreLivechatRoomCreatePrevent';
+import type { IVisitorExternalIdentifier, IVisitor, ResolveVisitorContactData } from './IVisitor';
+import type { IVisitorEmail } from './IVisitorEmail';
+import type { IVisitorPhone } from './IVisitorPhone';
 
-export {
+export type {
 	IVisitorExternalIdentifier,
 	ILivechatEventContext,
 	ILivechatMessage,
@@ -41,8 +42,8 @@ export {
 	IVisitor,
 	IVisitorEmail,
 	IVisitorPhone,
-	LivechatTransferEventType,
 	IPostLivechatDepartmentRemoved,
 	IPostLivechatDepartmentDisabled,
 	ResolveVisitorContactData,
 };
+export { LivechatTransferEventType };