chore(eslint): Consistent type imports/exports#39341
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughSystematic conversion of value imports and exports to type-only imports and exports across 100+ files. Changes include converting Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes The PR involves 100+ files with consistent, repetitive type import/export refactoring. While individual file changes are simple and straightforward, the large volume and heterogeneity across multiple packages (core-typings, ui-kit, services, etc.) requires systematic verification. ESLint configuration changes require careful review to ensure enforcement is correct. No functional logic changes or breaking control flow modifications present. Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #39341 +/- ##
===========================================
- Coverage 70.89% 70.86% -0.04%
===========================================
Files 3207 3196 -11
Lines 113334 113235 -99
Branches 20538 20504 -34
===========================================
- Hits 80349 80242 -107
- Misses 30940 30943 +3
- Partials 2045 2050 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/jira ARCH-2021 |
Proposed changes (including videos or screenshots)
It enforces consistent type imports and exports via ESLint.
Further comments
It's a replacement for
verbatimModuleSyntaxsince we don't support ESM yet.Task: ARCH-2042
Summary by CodeRabbit
Release Notes