Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
860fe79
chore(deps,eslint): upgrade ESLint
tassoevan Feb 21, 2026
9f0cb37
chore(eslint): add more ignored files
tassoevan Feb 21, 2026
d124466
chore(eslint): remove direct references to the react config
tassoevan Feb 22, 2026
7c090fd
chore(eslint): remove obsolete `--ext` CLI flag
tassoevan Feb 22, 2026
eca1ada
chore(eslint): normalize CLI's path argument
tassoevan Feb 22, 2026
1ab9da2
chore(eslint): brute-force a unified ESLint config
tassoevan Feb 23, 2026
95801cd
chore(eslint): compact configs a little bit
tassoevan Feb 24, 2026
6e58590
chore(eslint): warn unused disable directives
tassoevan Feb 24, 2026
1bc0f2a
chore(eslint): install config package at monorepo root
tassoevan Feb 24, 2026
4bdae16
chore(eslint): undeclare rules overwritten by Prettier
tassoevan Feb 24, 2026
69bc384
chore(eslint): compact configuration a little bit more
tassoevan Feb 25, 2026
fc5aac8
chore(eslint): compact configuration a little bit more
tassoevan Feb 25, 2026
d7bdf99
chore(eslint): turn `@rocket.chat/eslint-config` into a ESM package
tassoevan Feb 25, 2026
4ba6ebf
chore(eslint): resolve Meteor packages' types before linting
tassoevan Feb 25, 2026
9214d50
chore(eslint): upgrade to ESLint 9
tassoevan Feb 25, 2026
096a80e
chore(eslint): use React configs
tassoevan Feb 26, 2026
da6be39
chore(eslint): attach recommended javascript configuration
tassoevan Feb 26, 2026
c0b146f
chore(eslint): attach recommended typescript configuration
tassoevan Feb 26, 2026
05dee87
chore(eslint): ease some workarounds
tassoevan Feb 26, 2026
3bce266
chore(eslint): move jest and testing-library plugins to eslint-config
tassoevan Feb 26, 2026
8f73be4
chore(eslint): ignore workspaces under `scripts/` (for now?)
tassoevan Feb 26, 2026
948dfe5
chore(eslint): condense globs
tassoevan Feb 26, 2026
45f4f58
chore(eslint): ignore `meteor/*` in `import/no-unresolved`
tassoevan Feb 26, 2026
c769780
chore(eslint): handle `getAbsolutePath` cross-platform support
tassoevan Feb 26, 2026
bfbc553
chore: add changeset
tassoevan Feb 26, 2026
c7c7b8a
Merge branch 'develop' into chore/eslint-upgrade
tassoevan Feb 27, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions .changeset/little-eyes-kneel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
---
'@rocket.chat/eslint-config': minor
'@rocket.chat/server-cloud-communication': patch
'@rocket.chat/omnichannel-services': patch
'@rocket.chat/omnichannel-transcript': patch
'@rocket.chat/authorization-service': patch
'@rocket.chat/federation-matrix': patch
'@rocket.chat/web-ui-registration': patch
'@rocket.chat/network-broker': patch
'@rocket.chat/password-policies': patch
'@rocket.chat/release-changelog': patch
'@rocket.chat/storybook-config': patch
'@rocket.chat/presence-service': patch
'@rocket.chat/omni-core-ee': patch
'@rocket.chat/fuselage-ui-kit': patch
'@rocket.chat/instance-status': patch
'@rocket.chat/media-signaling': patch
'@rocket.chat/patch-injection': patch
'@rocket.chat/account-service': patch
'@rocket.chat/media-calls': patch
'@rocket.chat/message-parser': patch
'@rocket.chat/mock-providers': patch
'@rocket.chat/release-action': patch
'@rocket.chat/pdf-worker': patch
'@rocket.chat/ui-theming': patch
'@rocket.chat/account-utils': patch
'@rocket.chat/core-services': patch
'@rocket.chat/message-types': patch
'@rocket.chat/model-typings': patch
'@rocket.chat/mongo-adapter': patch
'@rocket.chat/ui-video-conf': patch
'@rocket.chat/uikit-playground': patch
'@rocket.chat/cas-validate': patch
'@rocket.chat/core-typings': patch
'@rocket.chat/jest-presets': patch
'@rocket.chat/peggy-loader': patch
'@rocket.chat/rest-typings': patch
'@rocket.chat/server-fetch': patch
'@rocket.chat/ddp-streamer': patch
'@rocket.chat/queue-worker': patch
'@rocket.chat/presence': patch
'@rocket.chat/apps-engine': patch
'@rocket.chat/desktop-api': patch
'@rocket.chat/http-router': patch
'@rocket.chat/poplib': patch
'@rocket.chat/ui-composer': patch
'@rocket.chat/ui-contexts': patch
'@rocket.chat/license': patch
'@rocket.chat/api-client': patch
'@rocket.chat/ddp-client': patch
'@rocket.chat/log-format': patch
'@rocket.chat/gazzodown': patch
'@rocket.chat/omni-core': patch
'@rocket.chat/ui-avatar': patch
'@rocket.chat/ui-client': patch
'@rocket.chat/livechat': patch
'@rocket.chat/abac': patch
'@rocket.chat/favicon': patch
'@rocket.chat/tracing': patch
'@rocket.chat/ui-voip': patch
'@rocket.chat/agenda': patch
'@rocket.chat/base64': patch
'@rocket.chat/logger': patch
'@rocket.chat/models': patch
'@rocket.chat/random': patch
'@rocket.chat/sha256': patch
'@rocket.chat/ui-kit': patch
'@rocket.chat/tools': patch
'@rocket.chat/apps': patch
'@rocket.chat/cron': patch
'@rocket.chat/i18n': patch
'@rocket.chat/jwt': patch
'@rocket.chat/meteor': patch
---

chore(eslint): Upgrades ESLint and its configuration
2 changes: 0 additions & 2 deletions .github/workflows/ci-code-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ jobs:

- name: Cache TypeCheck
uses: actions/cache@v5
if: matrix.check == 'ts'
with:
path: ./apps/meteor/tsconfig.typecheck.tsbuildinfo
key: typecheck-cache-${{ runner.OS }}-${{ hashFiles('yarn.lock') }}-${{ github.event.issue.number }}
Expand All @@ -66,7 +65,6 @@ jobs:
typecheck-cache

- name: Install Meteor
if: matrix.check == 'ts'
shell: bash
run: |
# Restore bin from cache
Expand Down
18 changes: 0 additions & 18 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,22 +1,4 @@
{
"eslint.workingDirectories": [
{
"pattern": "packages/*",
"changeProcessCWD": true
},
{
"pattern": "apps/*",
"changeProcessCWD": true
},
{
"pattern": "ee/apps/*",
"changeProcessCWD": true
},
{
"pattern": "ee/packages/*",
"changeProcessCWD": true
}
],
"typescript.tsdk": "./node_modules/typescript/lib",
"cSpell.words": [
"autotranslate",
Expand Down
156 changes: 0 additions & 156 deletions apps/meteor/.eslintrc.json

This file was deleted.

21 changes: 3 additions & 18 deletions apps/meteor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
"dev": "NODE_OPTIONS=\"--trace-warnings\" meteor --exclude-archs \"web.browser.legacy, web.cordova\"",
"docker:start": "docker-compose up",
"dsv": "meteor npm run dev",
"eslint": "NODE_OPTIONS=\"--max-old-space-size=8192\" eslint --ext .js,.jsx,.ts,.tsx . --cache",
"eslint": "NODE_OPTIONS=\"--max-old-space-size=8192\" eslint --cache",
"eslint:fix": "yarn eslint --fix",
"ha": "meteor npm run ha:start",
"ha:add": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' ts-node .scripts/run-ha.ts instance",
"ha:start": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' ts-node .scripts/run-ha.ts main",
"lint": "yarn stylelint && yarn eslint",
"lint": "yarn stylelint && meteor lint && yarn eslint .",
"migration:add": "ts-node-transpile-only --skip-project .scripts/make-migration.ts",
"ms": "TRANSPORTER=${TRANSPORTER:-TCP} meteor npm run dev",
"obj:dev": "TEST_MODE=true yarn dev",
Expand Down Expand Up @@ -309,14 +309,12 @@
"devDependencies": {
"@axe-core/playwright": "^4.10.2",
"@babel/core": "~7.28.6",
"@babel/eslint-parser": "~7.28.6",
"@babel/preset-env": "~7.28.6",
"@babel/preset-react": "~7.27.1",
"@babel/register": "~7.28.6",
"@faker-js/faker": "~8.0.2",
"@playwright/test": "^1.52.0",
"@rocket.chat/desktop-api": "workspace:~",
"@rocket.chat/eslint-config": "workspace:^",
"@rocket.chat/jest-presets": "workspace:~",
"@rocket.chat/livechat": "workspace:^",
"@rocket.chat/mock-providers": "workspace:^",
Expand Down Expand Up @@ -400,8 +398,6 @@
"@types/underscore": "^1.13.0",
"@types/xml-crypto": "~1.4.6",
"@types/xml-encryption": "~1.2.4",
"@typescript-eslint/eslint-plugin": "~5.60.1",
"@typescript-eslint/parser": "~5.60.1",
"autoprefixer": "^9.8.8",
"babel-loader": "~10.0.0",
"babel-plugin-array-includes": "^2.0.3",
Expand All @@ -414,18 +410,7 @@
"cross-env": "^7.0.3",
"docker-compose": "^0.24.8",
"emojione-assets": "^4.5.0",
"eslint": "~8.45.0",
"eslint-config-prettier": "~9.1.2",
"eslint-plugin-anti-trojan-source": "~1.1.2",
"eslint-plugin-import": "~2.31.0",
"eslint-plugin-no-floating-promise": "~2.0.0",
"eslint-plugin-playwright": "~2.2.2",
"eslint-plugin-prettier": "~5.2.6",
"eslint-plugin-react": "~7.37.5",
"eslint-plugin-react-hooks": "~5.0.0",
"eslint-plugin-storybook": "~0.11.6",
"eslint-plugin-testing-library": "~6.4.0",
"eslint-plugin-you-dont-need-lodash-underscore": "~6.14.0",
"eslint": "~9.39.3",
"fast-glob": "^3.3.3",
"i18next": "~23.4.9",
"jest": "~30.2.0",
Expand Down
6 changes: 0 additions & 6 deletions apps/meteor/packages/.eslintrc.json

This file was deleted.

5 changes: 0 additions & 5 deletions apps/meteor/packages/rocketchat-i18n/.eslintrc.json

This file was deleted.

37 changes: 0 additions & 37 deletions apps/meteor/tests/e2e/.eslintrc.json

This file was deleted.

Loading
Loading