Skip to content

fix: Seats pie chart overlaps the text below in Subscription page#37802

Open
Anshumancanrock wants to merge 3 commits into
RocketChat:developfrom
Anshumancanrock:ui-fix
Open

fix: Seats pie chart overlaps the text below in Subscription page#37802
Anshumancanrock wants to merge 3 commits into
RocketChat:developfrom
Anshumancanrock:ui-fix

Conversation

@Anshumancanrock

@Anshumancanrock Anshumancanrock commented Dec 14, 2025

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

This PR fixes a visual alignment issue on the Subscription page where the Seats donut chart was overlapping the text below it.

The Problem:

The bottom arc of the donut chart was touching/overlapping the seat count (e.g., "1 / 50") and the label ("49 Seats Available"), making the UI look cluttered and hard to read.

The Fix:

Added mbe={8} (margin-bottom of 8px) to the chart container in UsagePieGraph.tsx. This creates proper spacing between the donut chart and the text elements below it.

Before: Chart touches/overlaps the text below

image

After: Clean 8px gap between chart and text

Screenshot 2025-12-14 144801

Issue(s)

Closes #37786

Steps to test or reproduce

  1. Log in as an admin
  2. Navigate to Administration → Workspace → Subscription
  3. Scroll to the Seats widget (requires a license with seat limits to see the donut chart)
  4. Observe that the donut chart now has proper spacing and does not overlap the seat count or "Seats Available" text

Summary by CodeRabbit

  • Style
    • Improved visual spacing on the subscription usage pie chart for enhanced readability.

✏️ Tip: You can customize this high-level summary in your review settings.

@Anshumancanrock Anshumancanrock requested a review from a team as a code owner December 14, 2025 10:17
@changeset-bot

changeset-bot Bot commented Dec 14, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5998051

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Dec 14, 2025

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@coderabbitai

coderabbitai Bot commented Dec 14, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This PR adds a bottom margin to the pie chart component in the subscription admin page, resolving visual overlap between the chart and the content below it.

Changes

Cohort / File(s) Change Summary
UI Spacing Fix
apps/meteor/client/views/admin/subscription/components/UsagePieGraph.tsx
Added mbe={8} bottom margin prop to outer Box element wrapping the Pie chart to increase vertical spacing and prevent overlap with content below

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • aleksandernsilva

Poem

🐰 A spacing fix, so neat and small,
The chart now breathes with room to sprawl,
No overlap, just harmony,
Eight pixels of serenity! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'UI fix' is vague and generic, lacking specificity about which UI component or issue is being addressed. Consider using a more descriptive title that identifies the specific component being fixed, such as 'Fix Seats pie chart overlap in Subscription page' or 'Add spacing to UsagePieGraph to prevent text overlap'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The pull request directly addresses the objectives of issue #37786 by adding bottom margin spacing to the chart container, eliminating the overlap between the donut chart and underlying text elements.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the UsagePieGraph.tsx component with only a margin addition, directly addressing the linked issue with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Anshumancanrock Anshumancanrock changed the title UI fix fix: Seats pie chart overlaps the text below in Subscription page Dec 14, 2025
@Anshumancanrock

Copy link
Copy Markdown
Contributor Author

hi @dougfabris , could you please review this PR? Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seats pie chart overlaps the text below in Subscription page

2 participants