Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/big-fireants-leave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@rocket.chat/apps-engine': patch
'@rocket.chat/meteor': patch
---

Fixes an issue where apps that import node native modules with the optional `node:` specifier would fail to construct
29 changes: 16 additions & 13 deletions packages/apps-engine/deno-runtime/handlers/app/construct.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,25 @@ function prepareEnvironment() {
// 2. To require external npm packages we may provide
// 3. To require apps-engine files
function buildRequire(): (module: string) => unknown {
return (module: string): unknown => {
if (ALLOWED_NATIVE_MODULES.includes(module)) {
return require(`node:${module}`);
}
return (module: string): unknown => {
// Normalize Node built-in specifiers: accept both 'crypto' and 'node:crypto'
const normalized = module.replace('node:', '');

if (ALLOWED_EXTERNAL_MODULES.includes(module)) {
return require(`npm:${module}`);
}
if (ALLOWED_NATIVE_MODULES.includes(normalized)) {
return require(`node:${normalized}`);
}

if (module.startsWith('@rocket.chat/apps-engine')) {
// Our `require` function knows how to handle these
return require(module);
}
if (ALLOWED_EXTERNAL_MODULES.includes(module)) {
return require(`npm:${module}`);
}

throw new Error(`Module ${module} is not allowed`);
};
if (module.startsWith('@rocket.chat/apps-engine')) {
// Our `require` function knows how to handle these
return require(module);
}

throw new Error(`Module ${module} is not allowed`);
};
}

function wrapAppCode(code: string): (require: (module: string) => unknown) => Promise<Record<string, unknown>> {
Expand Down
Loading